You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2021/01/12 19:43:17 UTC

[superset] branch hugh-fix-confirmDatasetStyle created (now d63ceb5)

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a change to branch hugh-fix-confirmDatasetStyle
in repository https://gitbox.apache.org/repos/asf/superset.git.


      at d63ceb5  fix style

This branch includes the following new commits:

     new 4433dfe  set height
     new d63ceb5  fix style

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[superset] 01/02: set height

Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch hugh-fix-confirmDatasetStyle
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 4433dfee494a8db1b4167579eca125cc4584b516
Author: hughhhh <hu...@gmail.com>
AuthorDate: Mon Jan 11 22:23:49 2021 -0500

    set height
---
 superset-frontend/src/datasource/ChangeDatasourceModal.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx
index 1ab8249..77f85b7 100644
--- a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx
+++ b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx
@@ -221,7 +221,7 @@ const ChangeDatasourceModal: FunctionComponent<ChangeDatasourceModalProps> = ({
       onHide={onHide}
       responsive
       title={t('Change Dataset')}
-      height="350px"
+      height={confirmChange ? '50px' : '350px'}
       footer={
         <>
           {confirmChange && (

[superset] 02/02: fix style

Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch hugh-fix-confirmDatasetStyle
in repository https://gitbox.apache.org/repos/asf/superset.git

commit d63ceb5bf4b4eb1a4a2f04fb1c42f148b63442f4
Author: hughhhh <hu...@gmail.com>
AuthorDate: Tue Jan 12 14:42:32 2021 -0500

    fix style
---
 superset-frontend/src/datasource/ChangeDatasourceModal.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx
index 77f85b7..d3f4bb4 100644
--- a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx
+++ b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx
@@ -221,7 +221,7 @@ const ChangeDatasourceModal: FunctionComponent<ChangeDatasourceModalProps> = ({
       onHide={onHide}
       responsive
       title={t('Change Dataset')}
-      height={confirmChange ? '50px' : '350px'}
+      width={confirmChange ? '432px' : ''}
       footer={
         <>
           {confirmChange && (