You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by GitBox <gi...@apache.org> on 2021/05/09 12:54:23 UTC
[GitHub] [openwebbeans] melloware opened a new pull request #33: OWB-1298: Exclude Mojarra 2.3
melloware opened a new pull request #33:
URL: https://github.com/apache/openwebbeans/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #33: OWB-1298: Exclude Mojarra 2.3
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on a change in pull request #33:
URL: https://github.com/apache/openwebbeans/pull/33#discussion_r628897340
##########
File path: webbeans-impl/src/main/resources/META-INF/openwebbeans/openwebbeans.properties
##########
@@ -220,6 +220,7 @@ org.apache.webbeans.scanExclusionPaths=/jre/lib, \
/jsp-api, \
/myfaces-api, \
/myfaces-impl, \
+ /jakarta.faces, \
Review comment:
shouldn't it be jakarta as "javax" is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #33: OWB-1298: Exclude Mojarra 2.3
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on a change in pull request #33:
URL: https://github.com/apache/openwebbeans/pull/33#discussion_r629309692
##########
File path: webbeans-impl/src/main/resources/META-INF/openwebbeans/openwebbeans.properties
##########
@@ -220,6 +220,7 @@ org.apache.webbeans.scanExclusionPaths=/jre/lib, \
/jsp-api, \
/myfaces-api, \
/myfaces-impl, \
+ /jakarta.faces, \
Review comment:
javax.faces exists too.
I'm fine you say it shouldnt be excluded but then javax token is wrong too.
Overall the point is javax and jakarta must be handled the same way as of today before we can merge it (think jakarta.faces does not need scanning so i would exclude it until it changed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #33: OWB-1298: Exclude Mojarra 2.3
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on a change in pull request #33:
URL: https://github.com/apache/openwebbeans/pull/33#discussion_r629337241
##########
File path: webbeans-impl/src/main/resources/META-INF/openwebbeans/openwebbeans.properties
##########
@@ -220,6 +220,7 @@ org.apache.webbeans.scanExclusionPaths=/jre/lib, \
/jsp-api, \
/myfaces-api, \
/myfaces-impl, \
+ /jakarta.faces, \
Review comment:
my 2cts would be that any exclude is wong but generally works until a naming breaks it
afaik jakarta.faces does not need to be scanned so i wouldnt make it specific by itself but also because it would be a jakarta/javax change (guess we missed that exclusion when we made jakarta package integration for openwebbeans since we don't use mojarra in the core project)
it is kind of consistent with your mention, javax.faces was ok being excluded so jakarta.faces should be.
side note (not sure it is clear): excluded means not scanned by OWB but an extension can still add beans, it is not "fully ignore this jar", just "don't look for beans through its .class").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwebbeans] melloware commented on a change in pull request #33: OWB-1298: Exclude Mojarra 2.3
Posted by GitBox <gi...@apache.org>.
melloware commented on a change in pull request #33:
URL: https://github.com/apache/openwebbeans/pull/33#discussion_r629324468
##########
File path: webbeans-impl/src/main/resources/META-INF/openwebbeans/openwebbeans.properties
##########
@@ -220,6 +220,7 @@ org.apache.webbeans.scanExclusionPaths=/jre/lib, \
/jsp-api, \
/myfaces-api, \
/myfaces-impl, \
+ /jakarta.faces, \
Review comment:
I am not sure who added `javax` here but it seems wrong to me. and this problem with Mojarra only started with the GlassFish JARs when they got renamed to jakarta.faces. the old javax versions of these JARS do not expose the issue. I just know the above exclude definitely fixes the problem in OWB-1298.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwebbeans] melloware commented on a change in pull request #33: OWB-1298: Exclude Mojarra 2.3
Posted by GitBox <gi...@apache.org>.
melloware commented on a change in pull request #33:
URL: https://github.com/apache/openwebbeans/pull/33#discussion_r629286820
##########
File path: webbeans-impl/src/main/resources/META-INF/openwebbeans/openwebbeans.properties
##########
@@ -220,6 +220,7 @@ org.apache.webbeans.scanExclusionPaths=/jre/lib, \
/jsp-api, \
/myfaces-api, \
/myfaces-impl, \
+ /jakarta.faces, \
Review comment:
I thought these libs were there maven coordinates which is...
```xml
<dependency>
<groupId>org.glassfish</groupId>
<artifactId>jakarta.faces</artifactId>
<version>2.3.16</version>
</dependency>
```
So I thought my choice above was the safest exclude.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwebbeans] tandraschko merged pull request #33: OWB-1298: Exclude Mojarra 2.3
Posted by GitBox <gi...@apache.org>.
tandraschko merged pull request #33:
URL: https://github.com/apache/openwebbeans/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openwebbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org