You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2023/06/30 01:45:17 UTC

[superset] branch master updated: chore: better styling alerts/reports modal (#24558)

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new aa6870b23c chore: better styling alerts/reports modal (#24558)
aa6870b23c is described below

commit aa6870b23c7cb91f98f03a990ae65df30c4903e0
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Thu Jun 29 18:45:11 2023 -0700

    chore: better styling alerts/reports modal (#24558)
---
 superset-frontend/src/features/alerts/AlertReportModal.tsx   | 12 ++++++++++--
 ...6-29_18-38_240d23c7f86f_update_tag_model_w_description.py |  4 ++--
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/superset-frontend/src/features/alerts/AlertReportModal.tsx b/superset-frontend/src/features/alerts/AlertReportModal.tsx
index ce46eb69f5..a6c039c38a 100644
--- a/superset-frontend/src/features/alerts/AlertReportModal.tsx
+++ b/superset-frontend/src/features/alerts/AlertReportModal.tsx
@@ -253,6 +253,15 @@ export const StyledInputContainer = styled.div`
   flex: 1;
   margin-top: 0;
 
+  input::-webkit-outer-spin-button,
+  input::-webkit-inner-spin-button {
+    -webkit-appearance: none;
+    margin: 0;
+  }
+  input[type='number'] {
+    -moz-appearance: textfield;
+  }
+
   .helper {
     display: block;
     color: ${({ theme }) => theme.colors.grayscale.base};
@@ -332,8 +341,7 @@ const StyledRadioGroup = styled(Radio.Group)`
 `;
 
 const StyledCheckbox = styled(AntdCheckbox)`
-  margin-left: ${({ theme }) => theme.gridUnit * 5.5}px;
-  margin-top: ${({ theme }) => theme.gridUnit}px;
+  margin-top: ${({ theme }) => theme.gridUnit * 2}px;
 `;
 
 // Notification Method components
diff --git a/superset/migrations/versions/2023-06-29_18-38_240d23c7f86f_update_tag_model_w_description.py b/superset/migrations/versions/2023-06-29_18-38_240d23c7f86f_update_tag_model_w_description.py
index 84a2e68754..dd35582019 100644
--- a/superset/migrations/versions/2023-06-29_18-38_240d23c7f86f_update_tag_model_w_description.py
+++ b/superset/migrations/versions/2023-06-29_18-38_240d23c7f86f_update_tag_model_w_description.py
@@ -17,14 +17,14 @@
 """update_tag_model_w_description
 
 Revision ID: 240d23c7f86f
-Revises: 6fbe660cac39
+Revises: 8e5b0fb85b9a
 Create Date: 2023-06-29 18:38:30.033529
 
 """
 
 # revision identifiers, used by Alembic.
 revision = "240d23c7f86f"
-down_revision = "6fbe660cac39"
+down_revision = "8e5b0fb85b9a"
 
 import sqlalchemy as sa
 from alembic import op