[GitHub] [beam] bvolpato commented on a diff in pull request #26352: Implement naive progress tracking at BoundedSourceAsSDFRestrictionTracker

["bvolpato (via GitHub)" <gi...@apache.org>]

bvolpato commented on code in PR #26352:
URL: https://github.com/apache/beam/pull/26352#discussion_r1171803125


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java:
##########
@@ -442,6 +443,19 @@ public void checkDone() throws IllegalStateException {
       public IsBounded isBounded() {
         return IsBounded.BOUNDED;
       }
+
+      @Override
+      public Progress getProgress() {
+        if (currentReader == null) {
+          return null;

Review Comment:
   We've replaced with Progress.NONE as a placeholder for this (0 work done, 1 remaining)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org