You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by vi...@collab.net on 2005/06/06 09:38:49 UTC
svn_cl__try
Hi all,
The variadic function svn_cl__try in
subversion/clients/cmdline/util.c has a parameter 'success' which may not
always be of use to the caller. This is the case with proplist-cmd.c file
where the passed parameter is named ignored_success.
If only svn_cl__try had tested NULL before setting success, we
could have avoided the use of the 'ignored_success' variable.
Thanks,
Vivek
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn_cl__try
Posted by kf...@collab.net.
<vi...@collab.net> writes:
> The variadic function svn_cl__try in
> subversion/clients/cmdline/util.c has a parameter 'success' which may not
> always be of use to the caller. This is the case with proplist-cmd.c file
> where the passed parameter is named ignored_success.
> If only svn_cl__try had tested NULL before setting success, we
> could have avoided the use of the 'ignored_success' variable.
I meant to do this and forgot, sorry. Fixed in r14989.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn_cl__try
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Mon, 6 Jun 2005 vivek@collab.net wrote:
> Hi all,
> The variadic function svn_cl__try in
> subversion/clients/cmdline/util.c has a parameter 'success' which may not
> always be of use to the caller. This is the case with proplist-cmd.c file
> where the passed parameter is named ignored_success.
> If only svn_cl__try had tested NULL before setting success, we
> could have avoided the use of the 'ignored_success' variable.
+1 to fix this. (I'd do it myself, but currently my WC has another patch
under development.)
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org