Re: [PR] These fixes address security related issues. (datasketches-java)

["leerho (via GitHub)" <gi...@apache.org>]

leerho commented on code in PR #509:
URL: https://github.com/apache/datasketches-java/pull/509#discussion_r1501650715


##########
src/main/java/org/apache/datasketches/quantiles/DoublesSketchAccessor.java:
##########
@@ -39,13 +40,30 @@
   int numItems_;
   int offset_;
 
-  DoublesSketchAccessor(final DoublesSketch ds, final boolean forceSize, final int level) {
+  DoublesSketchAccessor(
+    final DoublesSketch ds,
+    final boolean forceSize,
+    final int level) {
+    this(checkLvl(level), ds, forceSize, level);
+  }
+
+  private DoublesSketchAccessor(
+      final boolean secure,

Review Comment:
   This "useless parameter" is actually a required part of the fix to avoid
   Finalizer Attacks.  See link at the top.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org