[jira] [Created] (SOLR-11687) SolrCore.getNewIndexDir returns the current index on most exceptions

["Erick Erickson (JIRA)" <ji...@apache.org>]

Erick Erickson created SOLR-11687:
-------------------------------------

             Summary: SolrCore.getNewIndexDir returns the current index on most exceptions
                 Key: SOLR-11687
                 URL: https://issues.apache.org/jira/browse/SOLR-11687
             Project: Solr
          Issue Type: Bug
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: Erick Erickson
            Assignee: Erick Erickson


I'll link the originating Solr JIRA in a minute (many thanks Nikolay). 

right at the top of this method we have this:

String result = dataDir + "index/";

If, for any reason, the method doesn't complete properly, the "result" is still returned. Now for instance, down in SolrCore.cleanupOldIndexDirectories the "old" directory is dataDir/index which may point to the current index.

This seems particularly dangerous:
{{
       try {
          p.load(new InputStreamReader(is, StandardCharsets.UTF_8));

          String s = p.getProperty("index");
          if (s != null && s.trim().length() > 0) {
              result = dataDir + s;
          }

        } catch (Exception e) {
          log.error("Unable to load " + IndexFetcher.INDEX_PROPERTIES, e);
        } finally {
          IOUtils.closeQuietly(is);
        }
 }}

Should "p.load" fail for any reason whatsoever, we'll still return dataDir/index.

Anyone want to chime on on what the expectations are here before I dive in?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org