You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2016/06/09 06:03:39 UTC

[GitHub] incubator-quickstep pull request #17: Serialized WorkOrders as proto.

GitHub user zuyu opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/17

    Serialized WorkOrders as proto.

    This large PR serializes `WorkOrders` as a proto, as a part of achieving distributed version.
    
    Note that this would affect the on-going work for adding new operators like window aggregation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-quickstep work-order-serialization

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17
    
----
commit 4cfaf459fe544c9332103d17c64d68d966b30f2b
Author: Zuyu Zhang <zz...@pivotal.io>
Date:   2016-04-12T23:55:48Z

    Serialized WorkOrders as proto.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #17: QUICKSTEP-10: WorkOrder Serialization.

Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/17
  
    @pateljm This PR is ready to merge, and has sync-ed with the master. Please take another look. Thanks!
    As for adding a document regarding how to add a new operator, we should do so in another separate PR, and write it in a `markdown` file in the `relational_operator` directory.
    
    @jianqiao I did some refactors for `TextScanOperator`:
     * Rewrote the code that generates `TextScanWorkOrder`s.
     * Use a `gflags` parameter for the const value `textscan_text_segment_size`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #17: QUICKSTEP-10: WorkOrder Serialization.

Posted by pateljm <gi...@git.apache.org>.
Github user pateljm commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/17
  
    Good suggestion @navsan ! Trying it now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #17: Serialized WorkOrders as proto.

Posted by pateljm <gi...@git.apache.org>.
Github user pateljm commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/17
  
    @zuyu -- Nice! LGTM. As you say, will have to rework the window aggregation branch later, but sounds like the changes are straightforward. To that effect, could you add a guide for what new operator writers need to follow w.r.t. the proto. This could go in ` query_execution/WorkOrderProtosContainer.hpp` (but you may have a better location for that comment). Ok -- to do that as a separate PR if you find that more convenient.   
    
    Can you merge the conflict -- sorry that may have been caused by the merge of PR#19.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #17: QUICKSTEP-10: WorkOrder Serialization.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quickstep/pull/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #17: QUICKSTEP-10: WorkOrder Serialization.

Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/17
  
    Interestingly, it was closed, but merged into master. But I did not do anything...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---