You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by "Istvan Toth (Jira)" <ji...@apache.org> on 2022/03/21 07:01:00 UTC

[jira] [Comment Edited] (PHOENIX-6658) Replace HRegion.get() calls

    [ https://issues.apache.org/jira/browse/PHOENIX-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509645#comment-17509645 ] 

Istvan Toth edited comment on PHOENIX-6658 at 3/21/22, 7:00 AM:
----------------------------------------------------------------

Committed to master and 5.1.

AFAICT HBase 1.x doesn't have off-heap cells, so this doesn't apply to 4.x.

Thanks for the reviews [~gjacoby] ,  [~apurtell] and [~elserj] .


was (Author: stoty):
Committed to master and 5.1.


AFAICT HBase 1.x doesn't have off-heap cells, so this doesn't apply to 4.x.

Thanks for the reviews [~apurtell] and [~elserj] .

> Replace HRegion.get() calls
> ---------------------------
>
>                 Key: PHOENIX-6658
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6658
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>             Fix For: 5.2.0, 5.1.3
>
>
> HBASE-26036 made a change where Region.get() always clones Off-Heap cells before returning them.
> In HBase all non-test occurances of this code were changed to create their own RegionScanner to avoid copying the off-heap cells. We should do the same.
> This would also let Phoenix run correctly with HBase 2.4.5-2.4.10 , as the fix in HBASE-26036  introduced another bug, HBASE-26777, which causes failures in Phoenix.
> Without this change, Phoenix needs at least HBase version 2.4.11, that has the fix for HBASE-26777.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)