You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "justinmclean (via GitHub)" <gi...@apache.org> on 2026/06/26 02:10:05 UTC
[PR] feat(skill): add contributor-to-committer readiness tracker [airflow-steward]
justinmclean opened a new pull request, #553:
URL: https://github.com/apache/airflow-steward/pull/553
## Summary
Adds `contributor-to-committer`, a read-only Mentoring-mode skill that maps a
contributor's GitHub activity against the adopter PMC's declared committer/PMC
thresholds and renders a traffic-light readiness brief (Ready to nominate /
Approaching / Not yet) plus the specific evidence gaps that remain. Produces
no GitHub mutations: every output is a draft the maintainer reviews.
## What's included
- **Skill** (`skills/contributor-to-committer/SKILL.md`): input resolution and
login validation, gh-based activity fetch (PRs, reviews, issues, comments,
area breadth), optional off-GitHub signal, threshold mapping, and brief
rendering. Treats all fetched external content as data, with injection
flagging.
- **Config template** (`projects/_template/committer-readiness.md`): per-project
committer and PMC thresholds, separate from `contributor-nomination-config.md`
so the tracker and the nomination brief can be tuned independently. Thresholds
are optional; the skill falls back to nomination config, then to a runtime
prompt.
- **Eval suite** (`tools/skill-evals/evals/contributor-to-committer/`): 13 cases
across input resolution (step 0), threshold mapping (step 4), and brief
rendering (step 5), including prompt-injection resistance at both the mapping
and render steps.
- Registration in `docs/labels-and-capabilities.md` and the `.agents`/`.claude`/
`.github` skill symlinks.
- Updates `tools/spec-loop/specs/mentoring-mode.md` to reflect that the
newcomer-facing capabilities it previously flagged as undesigned now ship.
## Threshold and traffic-light logic
A dimension is MET (>= threshold or threshold 0), APPROACHING (>= 50% of
threshold), or NOT_YET (< 50%). Mandatory dimensions are those with a threshold
> 0 plus off-GitHub when required; threshold-0 and undeclared dimensions are
advisory and auto-MET. The traffic light is exhaustive and mutually exclusive:
Ready when all mandatory dimensions are MET, Not yet when any is NOT_YET,
Approaching otherwise.
## Type of change
- [X] Skill change (`.claude/skills/<name>/`) — eval fixtures updated below
- [ ] Tool / bridge contract (`tools/<system>/*.md`)
- [ ] Python package (`tools/*/` with `pyproject.toml`)
- [ ] Groovy reference impl
- [ ] Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
- [ ] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`)
- [ ] Project template (`projects/_template/`)
- [ ] CI / dev loop (`prek`, workflows, validators)
- [ ] Other:
## Test plan
<!--
How you verified the change. Be specific. The reviewer reads this to
decide what to spot-check vs trust. Empty "ran the tests" doesn't help.
-->
- [X] `prek run --all-files` passes
- [ ] For Python packages touched: `uv run pytest` / `ruff check` / `mypy` passes
- [ ] For Groovy bridges touched: command-line invocation tested end-to-end
- [X] For skill changes: eval suite passes for the affected skill
(`PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/`)
- [ ] For skill *behaviour* changes: a new or updated eval fixture is included in this PR
(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
- [ ] Other:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(skill): add contributor-to-committer readiness tracker [airflow-steward]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on PR #553:
URL: https://github.com/apache/airflow-steward/pull/553#issuecomment-4805819359
## Correctness
No blocking findings. The two correctness defects found in the earlier passes are already resolved in this working tree (step-4 traffic-light unclassified band; case-3-not-yet fixture statuses), so they no longer appear in the diff under review.
advisory skills/contributor-to-committer/SKILL.md:245 — substantive-review heuristic keys partly on raw body length, which can misclassify a short-but-substantive review or a long boilerplate one.
A review is substantive if comments.totalCount >= 3 OR body length > 50.
Rule: thresholds on free-text length are coarse; acceptable as a heuristic but worth a comment noting it.
## Security
No blocking findings. Prompt-injection handling is explicitly specified and covered by two eval cases (step-4 case-5, step-5 case-4).
advisory skills/contributor-to-committer/SKILL.md:181,251,272 — query strings interpolate <login>, <upstream>, <since> into a double-quoted string, which sits in tension with the skill's own "never interpolate unescaped into shell double-quotes" instruction. <login> is regex-validated upstream so it's safe; <upstream> has no strict validation.
printf '%s' "repo:<upstream> type:pr author:<login> created:><since>"
Rule: pass values as printf args, or document why each interpolated token is safe.
## Conventions
No findings. SPDX headers present on all new non-symlink files; <angle-bracket> tokens in SKILL.md are intentional per the placeholder convention; capability registered in docs/labels-and-capabilities.md; the .github symlink now matches the sibling convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(skill): add contributor-to-committer readiness tracker [airflow-steward]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #553:
URL: https://github.com/apache/airflow-steward/pull/553#issuecomment-4816588534
Nice !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(skill): add contributor-to-committer readiness tracker [airflow-steward]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #553:
URL: https://github.com/apache/airflow-steward/pull/553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org