You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/05/25 19:14:56 UTC
[GitHub] [pinot] codecov-commenter commented on pull request #10804: Use min of (retry count, number of controller addresses) as retry count when fetch segment
codecov-commenter commented on PR #10804:
URL: https://github.com/apache/pinot/pull/10804#issuecomment-1563389930
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10804?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10804](https://app.codecov.io/gh/apache/pinot/pull/10804?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8e61b52) into [master](https://app.codecov.io/gh/apache/pinot/commit/fcaebab69a8a9d129cfae0130ab67c88815630bf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (fcaebab) will **decrease** coverage by `36.25%`.
> The diff coverage is `75.00%`.
```diff
@@ Coverage Diff @@
## master #10804 +/- ##
=============================================
- Coverage 67.84% 31.60% -36.25%
+ Complexity 6039 453 -5586
=============================================
Files 1626 2158 +532
Lines 84960 116109 +31149
Branches 13406 17564 +4158
=============================================
- Hits 57645 36696 -20949
- Misses 23313 76102 +52789
+ Partials 4002 3311 -691
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `24.10% <75.00%> (?)` | |
| unittests1 | `?` | |
| unittests2 | `13.68% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10804?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pinot/common/utils/fetcher/HttpSegmentFetcher.java](https://app.codecov.io/gh/apache/pinot/pull/10804?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvZmV0Y2hlci9IdHRwU2VnbWVudEZldGNoZXIuamF2YQ==) | `26.92% <75.00%> (+22.97%)` | :arrow_up: |
... and [1889 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10804/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org