You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/12 09:53:59 UTC

[GitHub] [mynewt-nimble] Reynevan94 opened a new pull request #771: Added advertiser to apps

Reynevan94 opened a new pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r393530036
 
 

 ##########
 File path: apps/beacon/src/main.c
 ##########
 @@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static const char *device_name = "Apache Mynewt";
+
+static void
+ble_app_set_addr(void)
+{
+    int rc;
+    ble_addr_t addr;
+
+    /* generate new non-resolvable private address */
+    rc = ble_hs_id_gen_rnd(1, &addr);
+    assert(rc == 0);
+
+    /* set generated address */
+    rc = ble_hs_id_set_rnd(addr.val);
+    assert(rc == 0);
+}
+
+/* adv_event() calls advertise(), so forward declaration is required */
+static void advertise(void);
+
+static int
+adv_event(struct ble_gap_event *event, void *arg)
+{
+    switch (event->type) {
+    case BLE_GAP_EVENT_ADV_COMPLETE:
+        MODLOG_DFLT(INFO,"Advertising completed, termination code: %d\n",
+                    event->adv_complete.reason);
+        advertise();
+        return 0;
+    default:
+        MODLOG_DFLT(ERROR, "Advertising event not handled\n");
+        return 0;
+    }
+}
+
+static void
+advertise(void)
+{
+    int rc;
+    struct ble_gap_adv_params adv_params;
+    struct ble_hs_adv_fields fields;
+
+    /* set adv parameters */
+    memset(&adv_params, 0, sizeof(adv_params));
+    adv_params.conn_mode = BLE_GAP_CONN_MODE_NON;
+    adv_params.disc_mode = BLE_GAP_DISC_MODE_GEN;
+
+    memset(&fields, 0, sizeof(fields));
+
+    /* Fill the fields with advertising data - flags, tx power level, name */
+    fields.flags = BLE_HS_ADV_F_DISC_GEN;
+    fields.tx_pwr_lvl_is_present = 1;
+    fields.tx_pwr_lvl = BLE_HS_ADV_TX_PWR_LVL_AUTO;
+    fields.name = (uint8_t *)device_name;
+    fields.name_len = strlen(device_name);
+    fields.name_is_complete = 1;
+
+    rc = ble_gap_adv_set_fields(&fields);
+    assert(rc == 0);
+
+    MODLOG_DFLT(INFO,"Starting advertising...\n");
+
+    /* As own address type we use hard-coded value, because we generate
+       NRPA and by definition it's random */
+    rc = ble_gap_adv_start(BLE_OWN_ADDR_RANDOM, NULL, 10000,
+                           &adv_params,adv_event, NULL);
+    assert(rc == 0);
+}
+
+static void
+on_sync(void)
+{
+    ble_app_set_addr();
+
+    /* begin advertising */
+    advertise();
+}
+
+static void
+on_reset(int reason)
+{
+    console_printf("Resetting state; reason=%d\n", reason);
 
 Review comment:
   should be modlog since you use it everywhere

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r393525211
 
 

 ##########
 File path: apps/beacon/src/main.c
 ##########
 @@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static const char *device_name = "Apache Mynewt";
+
+static void
+ble_app_set_addr(void)
 
 Review comment:
   `ble` prefix for local function name is confusing since it's used by nimble. `set_ble_addr` would be better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391572954
 
 

 ##########
 File path: apps/advertiser/src/main.c
 ##########
 @@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static uint8_t g_own_addr_type;
+
+static const char *device_name = "Apache Mynewt";
+
+static void 
+ble_app_set_addr(void)
+{
+    int rc;
+
+    /*define address variable*/
 
 Review comment:
   no need to comment variable, and all variables should be grouped together

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r393525729
 
 

 ##########
 File path: apps/beacon/src/main.c
 ##########
 @@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static const char *device_name = "Apache Mynewt";
+
+static void
+ble_app_set_addr(void)
+{
+    int rc;
+    ble_addr_t addr;
+
+    /* generate new non-resolvable private address */
+    rc = ble_hs_id_gen_rnd(1, &addr);
+    assert(rc == 0);
+
+    /* set generated address */
+    rc = ble_hs_id_set_rnd(addr.val);
+    assert(rc == 0);
+}
+
+/* adv_event() calls advertise(), so forward declaration is required */
+static void advertise(void);
 
 Review comment:
   put forward declaration before function definitions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#issuecomment-598713336
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#issuecomment-598691040
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### apps/beacon/src/main.c
   <details>
   
   ```diff
   @@ -33,12 +33,12 @@
    
    static const char *device_name = "Apache Mynewt";
    
   -static void 
   +static void
    ble_app_set_addr(void)
    {
        int rc;
        ble_addr_t addr;
   -    
   +
        /* generate new non-resolvable private address */
        rc = ble_hs_id_gen_rnd(1, &addr);
        assert(rc == 0);
   @@ -76,7 +76,7 @@
        /* set adv parameters */
        memset(&adv_params, 0, sizeof(adv_params));
        adv_params.conn_mode = BLE_GAP_CONN_MODE_NON;
   -    adv_params.disc_mode =  BLE_GAP_DISC_MODE_GEN;
   +    adv_params.disc_mode = BLE_GAP_DISC_MODE_GEN;
    
        memset(&fields, 0, sizeof(fields));
    
   @@ -87,25 +87,25 @@
        fields.name = (uint8_t *)device_name;
        fields.name_len = strlen(device_name);
        fields.name_is_complete = 1;
   -    
   +
        rc = ble_gap_adv_set_fields(&fields);
        assert(rc == 0);
   -    
   +
        MODLOG_DFLT(INFO,"Starting advertising...\n");
    
        /* As own address type we use hard-coded value, because we generate
   -    NRPA and by definition it's random */
   +       NRPA and by definition it's random */
        rc = ble_gap_adv_start(BLE_OWN_ADDR_RANDOM, NULL, 10000,
                               &adv_params,adv_event, NULL);
        assert(rc == 0);
    }
    
   -static void 
   +static void
    on_sync(void)
    {
        ble_app_set_addr();
    
   -   /* begin advertising */
   +    /* begin advertising */
        advertise();
    }
    
   @@ -115,7 +115,8 @@
        console_printf("Resetting state; reason=%d\n", reason);
    }
    
   -int main(int argc, char **argv)
   +int
   +main(int argc, char **argv)
    {
        int rc;
    
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391575678
 
 

 ##########
 File path: apps/advertiser/src/main.c
 ##########
 @@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static uint8_t g_own_addr_type;
+
+static const char *device_name = "Apache Mynewt";
+
+static void 
+ble_app_set_addr(void)
+{
+    int rc;
+
+    /*define address variable*/
+    ble_addr_t addr;
+    
+    /*generate new non-resolvable private address*/
+    rc = ble_hs_id_gen_rnd(1, &addr);
+    assert(rc == 0);
+
+    /*set generated address*/
+    rc = ble_hs_id_set_rnd(addr.val);
+    assert(rc == 0);
+}
+
+/*adv_event() calls advertise(), so forward declaration is required*/
+static void advertise(void);
+
+static int
+adv_event(struct ble_gap_event *event, void *arg)
+{
+    switch (event->type) {
+        default:
+            MODLOG_DFLT(ERROR, "Advertising event not handled\n");
+            return 0;
+        case BLE_GAP_EVENT_ADV_COMPLETE:
+            MODLOG_DFLT(INFO,"Code of termination reason: %d\n",
+                        event->adv_complete.reason);
+            advertise();
+            return 0;
+    }
+}
+
+static void
+advertise(void)
+{
+    int rc;
+
+    /*set adv parameters*/
+    struct ble_gap_adv_params adv_params;
+    struct ble_hs_adv_fields fields;
+
+    memset(&adv_params, 0, sizeof(adv_params));
+    adv_params.conn_mode = BLE_GAP_CONN_MODE_NON;
+    adv_params.disc_mode =  BLE_GAP_DISC_MODE_GEN;
+
+    memset(&fields, 0, sizeof(fields));
+
+    /*Fill the fields with advertising data - flags, tx power level, name*/
+    fields.flags = BLE_HS_ADV_F_DISC_GEN;
+    fields.tx_pwr_lvl_is_present = 1;
+    fields.tx_pwr_lvl = BLE_HS_ADV_TX_PWR_LVL_AUTO;
+    fields.name = (uint8_t *)device_name;
+    fields.name_len = strlen(device_name);
+    fields.name_is_complete = 1;
+    
+    rc = ble_gap_adv_set_fields(&fields);
+    assert(rc == 0);
+    
+    MODLOG_DFLT(INFO,"Starting advertising...\n");
+    /*performs discovery procedure*/
 
 Review comment:
   comment is misleading

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r393521818
 
 

 ##########
 File path: apps/beacon/src/main.c
 ##########
 @@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
 
 Review comment:
   this is already included above. also try to keep order of includes less random, i.e. start with system includes and then add host and services and the end.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r392162214
 
 

 ##########
 File path: apps/beacon/src/main.c
 ##########
 @@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static const char *device_name = "Apache Mynewt";
+
+static void 
+ble_app_set_addr(void)
+{
+    int rc;
+    ble_addr_t addr;
+    
+    /* generate new non-resolvable private address */
+    rc = ble_hs_id_gen_rnd(1, &addr);
+    assert(rc == 0);
+
+    /* set generated address */
+    rc = ble_hs_id_set_rnd(addr.val);
+    assert(rc == 0);
+}
+
+/* adv_event() calls advertise(), so forward declaration is required */
+static void advertise(void);
+
+static int
+adv_event(struct ble_gap_event *event, void *arg)
+{
+    switch (event->type) {
+    case BLE_GAP_EVENT_ADV_COMPLETE:
+        MODLOG_DFLT(INFO,"Advertising completed, termination code: %d\n",
+                    event->adv_complete.reason);
+        advertise();
+        return 0;
+    default:
+        MODLOG_DFLT(ERROR, "Advertising event not handled\n");
+        return 0;
+    }
+}
+
+static void
+advertise(void)
+{
+    int rc;
+
+    /* set adv parameters */
 
 Review comment:
   this comment should be in line 75
   also, keep variables declarations grouped together

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#issuecomment-598687658
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### apps/beacon/src/main.c
   <details>
   
   ```diff
   @@ -33,12 +33,12 @@
    
    static const char *device_name = "Apache Mynewt";
    
   -static void 
   +static void
    ble_app_set_addr(void)
    {
        int rc;
        ble_addr_t addr;
   -    
   +
        /* generate new non-resolvable private address */
        rc = ble_hs_id_gen_rnd(1, &addr);
        assert(rc == 0);
   @@ -76,7 +76,7 @@
        /* set adv parameters */
        memset(&adv_params, 0, sizeof(adv_params));
        adv_params.conn_mode = BLE_GAP_CONN_MODE_NON;
   -    adv_params.disc_mode =  BLE_GAP_DISC_MODE_GEN;
   +    adv_params.disc_mode = BLE_GAP_DISC_MODE_GEN;
    
        memset(&fields, 0, sizeof(fields));
    
   @@ -87,25 +87,25 @@
        fields.name = (uint8_t *)device_name;
        fields.name_len = strlen(device_name);
        fields.name_is_complete = 1;
   -    
   +
        rc = ble_gap_adv_set_fields(&fields);
        assert(rc == 0);
   -    
   +
        MODLOG_DFLT(INFO,"Starting advertising...\n");
    
        /* As own address type we use hard-coded value, because we generate
   -    NRPA and by definition it's random */
   +       NRPA and by definition it's random */
        rc = ble_gap_adv_start(BLE_OWN_ADDR_RANDOM, NULL, 10000,
                               &adv_params,adv_event, NULL);
        assert(rc == 0);
    }
    
   -static void 
   +static void
    on_sync(void)
    {
        ble_app_set_addr();
    
   -   /* begin advertising */
   +    /* begin advertising */
        advertise();
    }
    
   @@ -115,7 +115,8 @@
        console_printf("Resetting state; reason=%d\n", reason);
    }
    
   -int main(int argc, char **argv)
   +int
   +main(int argc, char **argv)
    {
        int rc;
    
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391572283
 
 

 ##########
 File path: apps/advertiser/.gitignore
 ##########
 @@ -0,0 +1,33 @@
+#
 
 Review comment:
   this file is not needed, we have top tree .gitignore which is handling all those

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391598289
 
 

 ##########
 File path: apps/advertiser/src/main.c
 ##########
 @@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static uint8_t g_own_addr_type;
+
+static const char *device_name = "Apache Mynewt";
+
+static void 
+ble_app_set_addr(void)
+{
+    int rc;
+
+    /*define address variable*/
+    ble_addr_t addr;
+    
+    /*generate new non-resolvable private address*/
+    rc = ble_hs_id_gen_rnd(1, &addr);
+    assert(rc == 0);
+
+    /*set generated address*/
+    rc = ble_hs_id_set_rnd(addr.val);
+    assert(rc == 0);
+}
+
+/*adv_event() calls advertise(), so forward declaration is required*/
+static void advertise(void);
+
+static int
+adv_event(struct ble_gap_event *event, void *arg)
+{
+    switch (event->type) {
+        default:
+            MODLOG_DFLT(ERROR, "Advertising event not handled\n");
+            return 0;
+        case BLE_GAP_EVENT_ADV_COMPLETE:
+            MODLOG_DFLT(INFO,"Code of termination reason: %d\n",
+                        event->adv_complete.reason);
+            advertise();
+            return 0;
+    }
+}
+
+static void
+advertise(void)
+{
+    int rc;
+
+    /*set adv parameters*/
+    struct ble_gap_adv_params adv_params;
+    struct ble_hs_adv_fields fields;
+
+    memset(&adv_params, 0, sizeof(adv_params));
+    adv_params.conn_mode = BLE_GAP_CONN_MODE_NON;
+    adv_params.disc_mode =  BLE_GAP_DISC_MODE_GEN;
+
+    memset(&fields, 0, sizeof(fields));
+
+    /*Fill the fields with advertising data - flags, tx power level, name*/
+    fields.flags = BLE_HS_ADV_F_DISC_GEN;
+    fields.tx_pwr_lvl_is_present = 1;
+    fields.tx_pwr_lvl = BLE_HS_ADV_TX_PWR_LVL_AUTO;
+    fields.name = (uint8_t *)device_name;
+    fields.name_len = strlen(device_name);
+    fields.name_is_complete = 1;
+    
+    rc = ble_gap_adv_set_fields(&fields);
+    assert(rc == 0);
+    
+    MODLOG_DFLT(INFO,"Starting advertising...\n");
+    /*performs discovery procedure*/
+    rc = ble_gap_adv_start(g_own_addr_type, NULL, 10000,
 
 Review comment:
   use BLE_OWN_ADDR_RANDOM here (since we set random address to NRPA)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r393524080
 
 

 ##########
 File path: apps/beacon/src/main.c
 ##########
 @@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static const char *device_name = "Apache Mynewt";
+
+static void
+ble_app_set_addr(void)
+{
+    int rc;
+    ble_addr_t addr;
+
+    /* generate new non-resolvable private address */
+    rc = ble_hs_id_gen_rnd(1, &addr);
+    assert(rc == 0);
+
+    /* set generated address */
+    rc = ble_hs_id_set_rnd(addr.val);
+    assert(rc == 0);
+}
+
+/* adv_event() calls advertise(), so forward declaration is required */
+static void advertise(void);
+
+static int
+adv_event(struct ble_gap_event *event, void *arg)
+{
+    switch (event->type) {
+    case BLE_GAP_EVENT_ADV_COMPLETE:
+        MODLOG_DFLT(INFO,"Advertising completed, termination code: %d\n",
 
 Review comment:
   missing whitespace

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] utzig commented on issue #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
utzig commented on issue #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#issuecomment-598683335
 
 
   @Reynevan94 Please rebase on latest master!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#issuecomment-598713336
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r393529563
 
 

 ##########
 File path: apps/beacon/syscfg.yml
 ##########
 @@ -0,0 +1,24 @@
+#
 
 Review comment:
   not really sure if we need `syscfg.yml` which does not define or set anything

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391572823
 
 

 ##########
 File path: apps/advertiser/src/main.c
 ##########
 @@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static uint8_t g_own_addr_type;
+
+static const char *device_name = "Apache Mynewt";
+
+static void 
+ble_app_set_addr(void)
+{
+    int rc;
+
+    /*define address variable*/
+    ble_addr_t addr;
+    
+    /*generate new non-resolvable private address*/
 
 Review comment:
   minor: all comments should be  /* text */

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#issuecomment-598687658
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### apps/beacon/src/main.c
   <details>
   
   ```diff
   @@ -33,12 +33,12 @@
    
    static const char *device_name = "Apache Mynewt";
    
   -static void 
   +static void
    ble_app_set_addr(void)
    {
        int rc;
        ble_addr_t addr;
   -    
   +
        /* generate new non-resolvable private address */
        rc = ble_hs_id_gen_rnd(1, &addr);
        assert(rc == 0);
   @@ -76,7 +76,7 @@
        /* set adv parameters */
        memset(&adv_params, 0, sizeof(adv_params));
        adv_params.conn_mode = BLE_GAP_CONN_MODE_NON;
   -    adv_params.disc_mode =  BLE_GAP_DISC_MODE_GEN;
   +    adv_params.disc_mode = BLE_GAP_DISC_MODE_GEN;
    
        memset(&fields, 0, sizeof(fields));
    
   @@ -87,25 +87,25 @@
        fields.name = (uint8_t *)device_name;
        fields.name_len = strlen(device_name);
        fields.name_is_complete = 1;
   -    
   +
        rc = ble_gap_adv_set_fields(&fields);
        assert(rc == 0);
   -    
   +
        MODLOG_DFLT(INFO,"Starting advertising...\n");
    
        /* As own address type we use hard-coded value, because we generate
   -    NRPA and by definition it's random */
   +       NRPA and by definition it's random */
        rc = ble_gap_adv_start(BLE_OWN_ADDR_RANDOM, NULL, 10000,
                               &adv_params,adv_event, NULL);
        assert(rc == 0);
    }
    
   -static void 
   +static void
    on_sync(void)
    {
        ble_app_set_addr();
    
   -   /* begin advertising */
   +    /* begin advertising */
        advertise();
    }
    
   @@ -115,7 +115,8 @@
        console_printf("Resetting state; reason=%d\n", reason);
    }
    
   -int main(int argc, char **argv)
   +int
   +main(int argc, char **argv)
    {
        int rc;
    
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391575435
 
 

 ##########
 File path: apps/advertiser/src/main.c
 ##########
 @@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static uint8_t g_own_addr_type;
+
+static const char *device_name = "Apache Mynewt";
+
+static void 
+ble_app_set_addr(void)
+{
+    int rc;
+
+    /*define address variable*/
+    ble_addr_t addr;
+    
+    /*generate new non-resolvable private address*/
+    rc = ble_hs_id_gen_rnd(1, &addr);
+    assert(rc == 0);
+
+    /*set generated address*/
+    rc = ble_hs_id_set_rnd(addr.val);
+    assert(rc == 0);
+}
+
+/*adv_event() calls advertise(), so forward declaration is required*/
+static void advertise(void);
+
+static int
+adv_event(struct ble_gap_event *event, void *arg)
+{
+    switch (event->type) {
+        default:
+            MODLOG_DFLT(ERROR, "Advertising event not handled\n");
+            return 0;
+        case BLE_GAP_EVENT_ADV_COMPLETE:
+            MODLOG_DFLT(INFO,"Code of termination reason: %d\n",
+                        event->adv_complete.reason);
+            advertise();
+            return 0;
+    }
+}
+
+static void
+advertise(void)
+{
+    int rc;
+
+    /*set adv parameters*/
+    struct ble_gap_adv_params adv_params;
+    struct ble_hs_adv_fields fields;
+
+    memset(&adv_params, 0, sizeof(adv_params));
+    adv_params.conn_mode = BLE_GAP_CONN_MODE_NON;
+    adv_params.disc_mode =  BLE_GAP_DISC_MODE_GEN;
+
+    memset(&fields, 0, sizeof(fields));
+
+    /*Fill the fields with advertising data - flags, tx power level, name*/
+    fields.flags = BLE_HS_ADV_F_DISC_GEN;
+    fields.tx_pwr_lvl_is_present = 1;
+    fields.tx_pwr_lvl = BLE_HS_ADV_TX_PWR_LVL_AUTO;
+    fields.name = (uint8_t *)device_name;
+    fields.name_len = strlen(device_name);
+    fields.name_is_complete = 1;
+    
+    rc = ble_gap_adv_set_fields(&fields);
+    assert(rc == 0);
+    
+    MODLOG_DFLT(INFO,"Starting advertising...\n");
+    /*performs discovery procedure*/
+    rc = ble_gap_adv_start(g_own_addr_type, NULL, 10000,
+                      &adv_params,adv_event, NULL);
 
 Review comment:
   fix indentation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r393528531
 
 

 ##########
 File path: apps/beacon/pkg.yml
 ##########
 @@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+pkg.name: "apps/beacon"
+pkg.type: app
+pkg.description: "Basic beacon application"
 
 Review comment:
   I'm not really sure if `beacon` is good name for this app, it's just simple `advertiser`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r392162214
 
 

 ##########
 File path: apps/beacon/src/main.c
 ##########
 @@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static const char *device_name = "Apache Mynewt";
+
+static void 
+ble_app_set_addr(void)
+{
+    int rc;
+    ble_addr_t addr;
+    
+    /* generate new non-resolvable private address */
+    rc = ble_hs_id_gen_rnd(1, &addr);
+    assert(rc == 0);
+
+    /* set generated address */
+    rc = ble_hs_id_set_rnd(addr.val);
+    assert(rc == 0);
+}
+
+/* adv_event() calls advertise(), so forward declaration is required */
+static void advertise(void);
+
+static int
+adv_event(struct ble_gap_event *event, void *arg)
+{
+    switch (event->type) {
+    case BLE_GAP_EVENT_ADV_COMPLETE:
+        MODLOG_DFLT(INFO,"Advertising completed, termination code: %d\n",
+                    event->adv_complete.reason);
+        advertise();
+        return 0;
+    default:
+        MODLOG_DFLT(ERROR, "Advertising event not handled\n");
+        return 0;
+    }
+}
+
+static void
+advertise(void)
+{
+    int rc;
+
+    /* set adv parameters */
 
 Review comment:
   this comment should be in line 78
   also, keep variables declarations grouped together

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek merged pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#issuecomment-600128681
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r393529245
 
 

 ##########
 File path: apps/beacon/pkg.yml
 ##########
 @@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+pkg.name: "apps/beacon"
+pkg.type: app
+pkg.description: "Basic beacon application"
+pkg.author: "Krzysztof Kopyściński krzysztof.kopyscinski@codecoup.pl"
 
 Review comment:
   email address should be inside `<>`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r393521103
 
 

 ##########
 File path: apps/beacon/pkg.yml
 ##########
 @@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+pkg.name: "apps/beacon"
+pkg.type: app
+pkg.description: "Basic beacon application"
+pkg.author: "Krzysztof Kopyściński krzysztof.kopyscinski@codecoup.pl"
+
+pkg.deps:
+    - "@apache-mynewt-core/kernel/os"
+    - "@apache-mynewt-core/sys/console/full"
+    - "@apache-mynewt-core/sys/log/full"
+    - "@apache-mynewt-core/sys/stats/full"
+    - "@apache-mynewt-nimble/nimble/host"
+    - "@apache-mynewt-nimble/nimble/host/store/config"
+    - "@apache-mynewt-nimble/nimble/transport"
+    - "@apache-mynewt-nimble/nimble/host/util/"
+    - "@apache-mynewt-nimble/nimble/host/services/gap"
+    - "@apache-mynewt-core/sys/log/modlog"
 
 Review comment:
   put all core pkgs first, then host, then transport

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#issuecomment-600016487
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391574971
 
 

 ##########
 File path: apps/advertiser/src/main.c
 ##########
 @@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static uint8_t g_own_addr_type;
+
+static const char *device_name = "Apache Mynewt";
+
+static void 
+ble_app_set_addr(void)
+{
+    int rc;
+
+    /*define address variable*/
+    ble_addr_t addr;
+    
+    /*generate new non-resolvable private address*/
+    rc = ble_hs_id_gen_rnd(1, &addr);
+    assert(rc == 0);
+
+    /*set generated address*/
+    rc = ble_hs_id_set_rnd(addr.val);
+    assert(rc == 0);
+}
+
+/*adv_event() calls advertise(), so forward declaration is required*/
+static void advertise(void);
+
+static int
+adv_event(struct ble_gap_event *event, void *arg)
+{
+    switch (event->type) {
+        default:
 
 Review comment:
   check coding style, shoudl be
   switch() {
   case:
   case:
   default:
   }
   
   
   also, it is common practice to have default case last

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r393523951
 
 

 ##########
 File path: apps/beacon/src/main.c
 ##########
 @@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static const char *device_name = "Apache Mynewt";
+
+static void
+ble_app_set_addr(void)
+{
+    int rc;
+    ble_addr_t addr;
+
+    /* generate new non-resolvable private address */
+    rc = ble_hs_id_gen_rnd(1, &addr);
+    assert(rc == 0);
+
+    /* set generated address */
+    rc = ble_hs_id_set_rnd(addr.val);
+    assert(rc == 0);
+}
+
+/* adv_event() calls advertise(), so forward declaration is required */
+static void advertise(void);
+
+static int
+adv_event(struct ble_gap_event *event, void *arg)
+{
+    switch (event->type) {
+    case BLE_GAP_EVENT_ADV_COMPLETE:
+        MODLOG_DFLT(INFO,"Advertising completed, termination code: %d\n",
+                    event->adv_complete.reason);
+        advertise();
+        return 0;
+    default:
+        MODLOG_DFLT(ERROR, "Advertising event not handled\n");
+        return 0;
+    }
+}
+
+static void
+advertise(void)
+{
+    int rc;
+    struct ble_gap_adv_params adv_params;
+    struct ble_hs_adv_fields fields;
+
+    /* set adv parameters */
+    memset(&adv_params, 0, sizeof(adv_params));
+    adv_params.conn_mode = BLE_GAP_CONN_MODE_NON;
+    adv_params.disc_mode = BLE_GAP_DISC_MODE_GEN;
+
+    memset(&fields, 0, sizeof(fields));
+
+    /* Fill the fields with advertising data - flags, tx power level, name */
+    fields.flags = BLE_HS_ADV_F_DISC_GEN;
+    fields.tx_pwr_lvl_is_present = 1;
+    fields.tx_pwr_lvl = BLE_HS_ADV_TX_PWR_LVL_AUTO;
+    fields.name = (uint8_t *)device_name;
+    fields.name_len = strlen(device_name);
+    fields.name_is_complete = 1;
+
+    rc = ble_gap_adv_set_fields(&fields);
+    assert(rc == 0);
+
+    MODLOG_DFLT(INFO,"Starting advertising...\n");
 
 Review comment:
   missing whitespace

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#issuecomment-600016487
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391597957
 
 

 ##########
 File path: apps/advertiser/src/main.c
 ##########
 @@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static uint8_t g_own_addr_type;
+
+static const char *device_name = "Apache Mynewt";
+
+static void 
+ble_app_set_addr(void)
+{
+    int rc;
+
+    /*define address variable*/
+    ble_addr_t addr;
+    
+    /*generate new non-resolvable private address*/
+    rc = ble_hs_id_gen_rnd(1, &addr);
+    assert(rc == 0);
+
+    /*set generated address*/
+    rc = ble_hs_id_set_rnd(addr.val);
+    assert(rc == 0);
+}
+
+/*adv_event() calls advertise(), so forward declaration is required*/
+static void advertise(void);
+
+static int
+adv_event(struct ble_gap_event *event, void *arg)
+{
+    switch (event->type) {
+        default:
+            MODLOG_DFLT(ERROR, "Advertising event not handled\n");
+            return 0;
+        case BLE_GAP_EVENT_ADV_COMPLETE:
+            MODLOG_DFLT(INFO,"Code of termination reason: %d\n",
+                        event->adv_complete.reason);
+            advertise();
+            return 0;
+    }
+}
+
+static void
+advertise(void)
+{
+    int rc;
+
+    /*set adv parameters*/
+    struct ble_gap_adv_params adv_params;
+    struct ble_hs_adv_fields fields;
+
+    memset(&adv_params, 0, sizeof(adv_params));
+    adv_params.conn_mode = BLE_GAP_CONN_MODE_NON;
+    adv_params.disc_mode =  BLE_GAP_DISC_MODE_GEN;
+
+    memset(&fields, 0, sizeof(fields));
+
+    /*Fill the fields with advertising data - flags, tx power level, name*/
+    fields.flags = BLE_HS_ADV_F_DISC_GEN;
+    fields.tx_pwr_lvl_is_present = 1;
+    fields.tx_pwr_lvl = BLE_HS_ADV_TX_PWR_LVL_AUTO;
+    fields.name = (uint8_t *)device_name;
+    fields.name_len = strlen(device_name);
+    fields.name_is_complete = 1;
+    
+    rc = ble_gap_adv_set_fields(&fields);
+    assert(rc == 0);
+    
+    MODLOG_DFLT(INFO,"Starting advertising...\n");
+    /*performs discovery procedure*/
+    rc = ble_gap_adv_start(g_own_addr_type, NULL, 10000,
+                      &adv_params,adv_event, NULL);
+    assert(rc == 0);
+}
+
+static void 
+on_sync(void)
+{
+    int rc;
+    /* Generate a non-resolvable private address. */
+    ble_app_set_addr();
+    
+    /*g_own_addr_type will store type of addres our BSP uses*/
 
 Review comment:
   sicne we are going to use NRPA address there is no need to infer address type since by definition it will be random

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#issuecomment-598691040
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### apps/beacon/src/main.c
   <details>
   
   ```diff
   @@ -33,12 +33,12 @@
    
    static const char *device_name = "Apache Mynewt";
    
   -static void 
   +static void
    ble_app_set_addr(void)
    {
        int rc;
        ble_addr_t addr;
   -    
   +
        /* generate new non-resolvable private address */
        rc = ble_hs_id_gen_rnd(1, &addr);
        assert(rc == 0);
   @@ -76,7 +76,7 @@
        /* set adv parameters */
        memset(&adv_params, 0, sizeof(adv_params));
        adv_params.conn_mode = BLE_GAP_CONN_MODE_NON;
   -    adv_params.disc_mode =  BLE_GAP_DISC_MODE_GEN;
   +    adv_params.disc_mode = BLE_GAP_DISC_MODE_GEN;
    
        memset(&fields, 0, sizeof(fields));
    
   @@ -87,25 +87,25 @@
        fields.name = (uint8_t *)device_name;
        fields.name_len = strlen(device_name);
        fields.name_is_complete = 1;
   -    
   +
        rc = ble_gap_adv_set_fields(&fields);
        assert(rc == 0);
   -    
   +
        MODLOG_DFLT(INFO,"Starting advertising...\n");
    
        /* As own address type we use hard-coded value, because we generate
   -    NRPA and by definition it's random */
   +       NRPA and by definition it's random */
        rc = ble_gap_adv_start(BLE_OWN_ADDR_RANDOM, NULL, 10000,
                               &adv_params,adv_event, NULL);
        assert(rc == 0);
    }
    
   -static void 
   +static void
    on_sync(void)
    {
        ble_app_set_addr();
    
   -   /* begin advertising */
   +    /* begin advertising */
        advertise();
    }
    
   @@ -115,7 +115,8 @@
        console_printf("Resetting state; reason=%d\n", reason);
    }
    
   -int main(int argc, char **argv)
   +int
   +main(int argc, char **argv)
    {
        int rc;
    
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r393523880
 
 

 ##########
 File path: apps/beacon/src/main.c
 ##########
 @@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "sysinit/sysinit.h"
+#include "os/os.h"
+#include "console/console.h"
+#include "host/ble_hs.h"
+#include "host/util/util.h"
+#include "services/gap/ble_svc_gap.h"
+#include "console/console.h"
+#include "log/log.h"
+
+static const char *device_name = "Apache Mynewt";
+
+static void
+ble_app_set_addr(void)
+{
+    int rc;
+    ble_addr_t addr;
+
+    /* generate new non-resolvable private address */
+    rc = ble_hs_id_gen_rnd(1, &addr);
+    assert(rc == 0);
+
+    /* set generated address */
+    rc = ble_hs_id_set_rnd(addr.val);
+    assert(rc == 0);
+}
+
+/* adv_event() calls advertise(), so forward declaration is required */
+static void advertise(void);
+
+static int
+adv_event(struct ble_gap_event *event, void *arg)
+{
+    switch (event->type) {
+    case BLE_GAP_EVENT_ADV_COMPLETE:
+        MODLOG_DFLT(INFO,"Advertising completed, termination code: %d\n",
+                    event->adv_complete.reason);
+        advertise();
+        return 0;
+    default:
+        MODLOG_DFLT(ERROR, "Advertising event not handled\n");
+        return 0;
+    }
+}
+
+static void
+advertise(void)
+{
+    int rc;
+    struct ble_gap_adv_params adv_params;
+    struct ble_hs_adv_fields fields;
+
+    /* set adv parameters */
+    memset(&adv_params, 0, sizeof(adv_params));
+    adv_params.conn_mode = BLE_GAP_CONN_MODE_NON;
+    adv_params.disc_mode = BLE_GAP_DISC_MODE_GEN;
+
+    memset(&fields, 0, sizeof(fields));
+
+    /* Fill the fields with advertising data - flags, tx power level, name */
+    fields.flags = BLE_HS_ADV_F_DISC_GEN;
+    fields.tx_pwr_lvl_is_present = 1;
+    fields.tx_pwr_lvl = BLE_HS_ADV_TX_PWR_LVL_AUTO;
+    fields.name = (uint8_t *)device_name;
+    fields.name_len = strlen(device_name);
+    fields.name_is_complete = 1;
+
+    rc = ble_gap_adv_set_fields(&fields);
+    assert(rc == 0);
+
+    MODLOG_DFLT(INFO,"Starting advertising...\n");
+
+    /* As own address type we use hard-coded value, because we generate
+       NRPA and by definition it's random */
+    rc = ble_gap_adv_start(BLE_OWN_ADDR_RANDOM, NULL, 10000,
+                           &adv_params,adv_event, NULL);
 
 Review comment:
   missing whitespace

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#issuecomment-598705760
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #771: Added advertiser to apps

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #771: Added advertiser to apps
URL: https://github.com/apache/mynewt-nimble/pull/771#issuecomment-598705760
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services