You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/04/25 15:10:28 UTC
[GitHub] [incubator-dolphinscheduler] zhongjiajie opened a new issue #2520: [Feature] Add static code test to codebase
zhongjiajie opened a new issue #2520:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2520
**Is your feature request related to a problem? Please describe.**
In PR https://github.com/apache/incubator-dolphinscheduler/pull/2363#discussion_r415080037 I found out we do not had static code check to our codebase, I think we should add some static test to avoid regression. WDYT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong closed issue #2520: [Feature] Add static code test/code style to codebase
Posted by GitBox <gi...@apache.org>.
dailidong closed issue #2520:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2520: [Feature] Add static code test/code style to codebase
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #2520:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2520#issuecomment-667691218
for new PR，please configure the checkstyle.xml and codestyle plugin to your ide. It will help to format the code.
[1] https://github.com/apache/incubator-dolphinscheduler/blob/dev/style/checkstyle.xml
[2] https://github.com/apache/incubator-dolphinscheduler/blob/dev/style/intellij-java-code-style.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zhongjiajie commented on issue #2520: [Feature] Add static code test/code style to codebase
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #2520:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2520#issuecomment-619399939
Related mail-list https://lists.apache.org/thread.html/r348ce4f6e11924defc11668b8799cd26a893f290890652888b4d33dc%40%3Cdev.dolphinscheduler.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2520: [Feature] Add static code test/code style to codebase
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #2520:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2520#issuecomment-660727997
good job
we will use the code style on dev branch when we merged PR that has already submitted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org