You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@crunch.apache.org by GitBox <gi...@apache.org> on 2019/04/18 17:42:24 UTC

[GitHub] [crunch] ben-roling commented on a change in pull request #22: CRUNCH-681: Updating HFileUtils to accept a filesystem parameter for …

ben-roling commented on a change in pull request #22: CRUNCH-681: Updating HFileUtils to accept a filesystem parameter for …
URL: https://github.com/apache/crunch/pull/22#discussion_r276765073
 
 

 ##########
 File path: crunch-hbase/src/main/java/org/apache/crunch/io/hbase/HFileUtils.java
 ##########
 @@ -384,6 +451,24 @@ public void process(Pair<ByteBuffer, Iterable<C>> input, Emitter<Result> emitter
     writeToHFilesForIncrementalLoad(cells, connection, tableName, outputPath, false);
   }
 
+  public static <C extends Cell> void writeToHFilesForIncrementalLoad(
 
 Review comment:
   javadoc for these 2 new public methods?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services