[GitHub] gianm commented on issue #6191: SQL: Support more result formats, add columns header.

[GitBox <gi...@apache.org>]

gianm commented on issue #6191: SQL: Support more result formats, add columns header.
URL: https://github.com/apache/incubator-druid/pull/6191#issuecomment-416010989
 
 
   I'm not a huge fan of the 'trailers' here, but from what I can see, our version of Jetty (9.4.10.v20180503) will use chunked encoding, with a well formed final chunk, even if we throw an exception in the middle of a StreamingOutput (despite https://bugs.eclipse.org/bugs/show_bug.cgi?id=424107 which claims this behavior is fixed). I verified this by writing a patch that throws an exception midstream, and confirming in wireshark that the final chunk is there. So that means it's impossible for clients to detect a truncated response without some kind of trailer in the body itself.
   
   Does anyone have any better ideas?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org