You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/07/08 10:00:16 UTC
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20406: OneDNN unit test file, small tidy up
anko-intel commented on a change in pull request #20406:
URL: https://github.com/apache/incubator-mxnet/pull/20406#discussion_r666049375
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -309,15 +319,18 @@ def check_batchnorm_training(stype):
data = mx.symbol.Variable('data', stype=stype)
in_location = [mx.nd.array(data_tmp).tostype(stype), mx.nd.array(gamma).tostype(stype),
mx.nd.array(beta).tostype(stype)]
- mean_std = [mx.nd.array(rolling_mean).tostype(stype), mx.nd.array(rolling_std).tostype(stype)]
+ mean_std = [mx.nd.array(rolling_mean).tostype(
Review comment:
```suggestion
mean_std = [mx.nd.array(rolling_mean).tostype(stype),
mx.nd.array(rolling_std).tostype(stype)]
```
or
```suggestion
mean_std =
[mx.nd.array(rolling_mean).tostype(stype),
mx.nd.array(rolling_std).tostype(stype)]
```
?
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -405,14 +420,18 @@ def check_pooling_training(stype):
in_location = [mx.nd.array(data_tmp).tostype(stype)]
if np.array(shape).shape[0] == 3:
- test = mx.symbol.Pooling(data=data, kernel=(3), stride=(2), pool_type='avg')
+ test = mx.symbol.Pooling(data=data, kernel=(
+ 3), stride=(2), pool_type='avg')
elif np.array(shape).shape[0] == 4:
- test = mx.symbol.Pooling(data=data, kernel=(3, 3), stride=(2, 2), pool_type='avg')
+ test = mx.symbol.Pooling(data=data, kernel=(
+ 3, 3), stride=(2, 2), pool_type='avg')
Review comment:
It looks strange when part of the parameter is moved to the next line. "(3, 3)" shouldn't' be spitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org