Re: Review Request 39967: RANGER-714 : Enhancements to the db admin setup scripts.

[Gautam Borad <gb...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39967/
-----------------------------------------------------------

(Updated Nov. 5, 2015, 2:41 p.m.)


Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-714
    https://issues.apache.org/jira/browse/RANGER-714


Repository: ranger


Description
-------

Attached patch contains below given changes to improve dba_script.py : 
1] Improve debugging for dba_script.py, printing jisql commands in the console without the password.
2] Removed "db connect" check during dryrun mode. 
3] dryrun mode now generates all the correct SQL statements required.


Diffs (updated)
-----

  agents-common/scripts/enable-agent.sh 32e922d93b8f273c4c4541f333c43ed06ce52630 
  hbase-agent/scripts/install.sh a7b67f3ef208dbccbbf3a57cf2044729738039b8 
  hdfs-agent/scripts/install.sh 9eef8dabaf75a55a7e2dca524dd4dfa19534efb6 
  hive-agent/scripts/install.sh cf7180dd3e4ead1ea328c205572aa13a18fe8b28 
  kms/scripts/db_setup.py bdac333b9186bd72e98acac91c0582239bc8b8d7 
  kms/scripts/dba_script.py d1da5d1513aee04f54453f76916df9a2d64d1212 
  kms/scripts/install.properties 247e499c319b001f4efb543e0358f3dce8baab6a 
  kms/scripts/setup.sh 94b6e233d3e521a92f751cf699bb692bfeee05e4 
  knox-agent/scripts/install.sh 271a2d44e1ca3959306cea7d9287f9e1f1f3a70d 
  plugin-kms/scripts/enable-kms-plugin.sh 468d39e1c3d03f5fbb8da924666a0fc151347811 
  security-admin/scripts/db_setup.py 07a06557c7d882a491b79d1aae387e20c1096aa2 
  security-admin/scripts/dba_script.py 40a6c496abcd8b8e07059456f5c557e5bcbfc758 
  security-admin/scripts/install.properties eb0c7ecb3b6d3c2f617ba9ca7b56a3eb5d9e2473 
  security-admin/scripts/setup.sh 11b72b4eca0ca5778ed9f6673d85cd9ce42b0c24 
  security-admin/src/bin/ranger_install.py 294f0da13e0258c5733fecd8cee2793f0d60495a 
  storm-agent/scripts/install.sh ab57bb996ee91948e9fc4b1638a3e25cdbe765f5 

Diff: https://reviews.apache.org/r/39967/diff/


Testing
-------

Below given testing has been done for all supported DB Flavors:
1] Oracle instance running with ServiceName or SID can be used from Ranger.
2] Tested execution of drymode generated SQL for creation of Ranger DB and User and installed Ranger in SeprateDBA mode.
3] Tested execution of drymode generated SQL for creation of KMS DB and User and installed KMS in SeprateDBA mode.
4] Tested dba_script.py execution in quite mode.
5] Validated executed jisql logs. Password values in Jisql logs were masked.
6] "db connect" not required to generate dryrun mode script.


Thanks,

Gautam Borad