You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/13 18:55:06 UTC
[GitHub] [superset] aehanno opened a new pull request, #20061: fix: Add french translation missing
aehanno opened a new pull request, #20061:
URL: https://github.com/apache/superset/pull/20061
### SUMMARY
Adding french translation
Change some code to activate translation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #20061:
URL: https://github.com/apache/superset/pull/20061#issuecomment-1181335900
@mathieudruart it appears you need to fix some linting errors in the translation file:
<img width="996" alt="image" src="https://user-images.githubusercontent.com/33317356/178416364-8a19ff27-57fe-4ed8-aa37-c00e2730025a.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mathieudruart commented on pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
mathieudruart commented on PR #20061:
URL: https://github.com/apache/superset/pull/20061#issuecomment-1212026303
> @mathieudruart it appears you need to fix some linting errors in the translation file:
>
> <img alt="image" width="996" src="https://user-images.githubusercontent.com/33317356/178416364-8a19ff27-57fe-4ed8-aa37-c00e2730025a.png">
Hi @villebro it should be fixed, is it possible to rerun the workflows ? Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on a diff in pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
aehanno commented on code in PR #20061:
URL: https://github.com/apache/superset/pull/20061#discussion_r873825648
##########
superset-frontend/src/views/CRUD/welcome/Welcome.tsx:
##########
@@ -279,7 +279,7 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
return (
<WelcomeContainer>
<WelcomeNav>
- <h1 className="welcome-header">Home</h1>
+ <h1 className="welcome-header">{t('Home')}</h1>
Review Comment:
correction is in this PR : https://github.com/apache/superset/pull/20078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #20061:
URL: https://github.com/apache/superset/pull/20061#discussion_r873438792
##########
superset-frontend/src/dashboard/components/SliceAdder.jsx:
##########
@@ -253,7 +254,7 @@ class SliceAdder extends React.Component {
value={this.state.sortBy}
onChange={this.handleSelect}
options={Object.entries(KEYS_TO_SORT).map(([key, label]) => ({
- label: t('Sort by %s', label),
+ label: t('Sort by %s', t(label)),
Review Comment:
This doesn't look right; you can't translate variables like this (the original code looks correct)
##########
superset-frontend/src/dashboard/components/dnd/AddSliceDragPreview.jsx:
##########
@@ -72,7 +73,7 @@ function AddSliceDragPreview({ dragItem, slices, isDragging, currentOffset }) {
transform: `translate(${currentOffset.x}px, ${currentOffset.y}px)`,
}}
sliceName={slice.slice_name}
- lastModified={slice.changed_on_humanized}
+ lastModified={moment.utc(slice.changed_on).fromNow()}
Review Comment:
same here
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -314,7 +314,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
<Divider />
<div>
<div className="section-title">{t('Actual time range')}</div>
- {validTimeRange && <div>{evalResponse}</div>}
+ {validTimeRange && <div>{t(evalResponse)}</div>}
Review Comment:
Again, you can't translate a variable (please see e.g. https://stackoverflow.com/questions/34579316/flask-babel-how-to-translate-variables for an explanation why this is the case)
##########
superset-frontend/src/dashboard/components/SliceAdder.jsx:
##########
@@ -221,7 +222,7 @@ class SliceAdder extends React.Component {
innerRef={dragSourceRef}
style={style}
sliceName={cellData.slice_name}
- lastModified={cellData.changed_on_humanized}
+ lastModified={moment.utc(cellData.changed_on).fromNow()}
Review Comment:
This should not be changed (@dpgaspar can comment in more detail, but IIRC, the `changed_on` property needs to be constructed in the backend right now)
##########
superset-frontend/src/views/CRUD/welcome/Welcome.tsx:
##########
@@ -279,7 +279,7 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
return (
<WelcomeContainer>
<WelcomeNav>
- <h1 className="welcome-header">Home</h1>
+ <h1 className="welcome-header">{t('Home')}</h1>
Review Comment:
Thanks for catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on a diff in pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
aehanno commented on code in PR #20061:
URL: https://github.com/apache/superset/pull/20061#discussion_r873825648
##########
superset-frontend/src/views/CRUD/welcome/Welcome.tsx:
##########
@@ -279,7 +279,7 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
return (
<WelcomeContainer>
<WelcomeNav>
- <h1 className="welcome-header">Home</h1>
+ <h1 className="welcome-header">{t('Home')}</h1>
Review Comment:
change has been move in this PR : https://github.com/apache/superset/pull/20078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
villebro merged PR #20061:
URL: https://github.com/apache/superset/pull/20061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mathieudruart commented on pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
mathieudruart commented on PR #20061:
URL: https://github.com/apache/superset/pull/20061#issuecomment-1165826702
Hi @villebro Is there anything we can do to help move this PR forward? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mathieudruart commented on pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
mathieudruart commented on PR #20061:
URL: https://github.com/apache/superset/pull/20061#issuecomment-1232066494
Hi @villebro do you know when this PR will be merged ? thank you !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
aehanno commented on PR #20061:
URL: https://github.com/apache/superset/pull/20061#issuecomment-1147594551
Hello @villebro,
I created 4 other pr from this one
I pinned you on each one, I hope to get your feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20061:
URL: https://github.com/apache/superset/pull/20061#issuecomment-1181336620
# [Codecov](https://codecov.io/gh/apache/superset/pull/20061?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20061](https://codecov.io/gh/apache/superset/pull/20061?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6032030) into [master](https://codecov.io/gh/apache/superset/commit/523bd8b79cfd48d1cb3a94f89c8095976844ce59?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (523bd8b) will **decrease** coverage by `11.97%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #20061 +/- ##
===========================================
- Coverage 66.55% 54.58% -11.98%
===========================================
Files 1692 1723 +31
Lines 64802 64649 -153
Branches 6657 6753 +96
===========================================
- Hits 43129 35286 -7843
- Misses 19973 27645 +7672
- Partials 1700 1718 +18
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.57% <ø> (+0.85%)` | :arrow_up: |
| python | `58.01% <ø> (-24.36%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `50.56% <ø> (+2.60%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20061?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/superset/pull/20061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/key\_value/commands/upsert.py](https://codecov.io/gh/apache/superset/pull/20061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3Vwc2VydC5weQ==) | `0.00% <0.00%> (-89.59%)` | :arrow_down: |
| [superset/key\_value/commands/update.py](https://codecov.io/gh/apache/superset/pull/20061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `0.00% <0.00%> (-89.37%)` | :arrow_down: |
| [superset/key\_value/commands/delete.py](https://codecov.io/gh/apache/superset/pull/20061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `0.00% <0.00%> (-85.30%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/20061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.19%)` | :arrow_down: |
| [superset/key\_value/commands/delete\_expired.py](https://codecov.io/gh/apache/superset/pull/20061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZV9leHBpcmVkLnB5) | `0.00% <0.00%> (-80.77%)` | :arrow_down: |
| [superset/dashboards/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/20061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjAucHk=) | `15.62% <0.00%> (-74.32%)` | :arrow_down: |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/20061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `24.03% <0.00%> (-69.59%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/superset/pull/20061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `25.88% <0.00%> (-68.24%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/superset/pull/20061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `30.18% <0.00%> (-67.93%)` | :arrow_down: |
| ... and [467 more](https://codecov.io/gh/apache/superset/pull/20061/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20061?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20061?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [523bd8b...6032030](https://codecov.io/gh/apache/superset/pull/20061?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on a diff in pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
aehanno commented on code in PR #20061:
URL: https://github.com/apache/superset/pull/20061#discussion_r873829467
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -314,7 +314,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
<Divider />
<div>
<div className="section-title">{t('Actual time range')}</div>
- {validTimeRange && <div>{evalResponse}</div>}
+ {validTimeRange && <div>{t(evalResponse)}</div>}
Review Comment:
chanhe has been move in this PR : https://github.com/apache/superset/pull/20080
We can discuss about translation of varaible in the ohter PR
Without the t() here, there are any translation, do you have an idea, where I can translate that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on a diff in pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
aehanno commented on code in PR #20061:
URL: https://github.com/apache/superset/pull/20061#discussion_r873835980
##########
superset-frontend/src/dashboard/components/SliceAdder.jsx:
##########
@@ -221,7 +222,7 @@ class SliceAdder extends React.Component {
innerRef={dragSourceRef}
style={style}
sliceName={cellData.slice_name}
- lastModified={cellData.changed_on_humanized}
+ lastModified={moment.utc(cellData.changed_on).fromNow()}
Review Comment:
changed_on_humanized has no translation. I will be glade to keep 'changed_on_humanized' but what can I change so that the translation is done
I move the change on this PR : https://github.com/apache/superset/pull/20082
we can discuss about that on the new PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
aehanno commented on PR #20061:
URL: https://github.com/apache/superset/pull/20061#issuecomment-1184481868
hey @villebro, correction of workflow has been made, it's possible to launch it ?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #20061:
URL: https://github.com/apache/superset/pull/20061#issuecomment-1232128764
Hey @mathieudruart , sorry for the delay; merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on a diff in pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
aehanno commented on code in PR #20061:
URL: https://github.com/apache/superset/pull/20061#discussion_r873830176
##########
superset-frontend/src/dashboard/components/SliceAdder.jsx:
##########
@@ -253,7 +254,7 @@ class SliceAdder extends React.Component {
value={this.state.sortBy}
onChange={this.handleSelect}
options={Object.entries(KEYS_TO_SORT).map(([key, label]) => ({
- label: t('Sort by %s', label),
+ label: t('Sort by %s', t(label)),
Review Comment:
PR: https://github.com/apache/superset/pull/20080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on a diff in pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
aehanno commented on code in PR #20061:
URL: https://github.com/apache/superset/pull/20061#discussion_r873835980
##########
superset-frontend/src/dashboard/components/SliceAdder.jsx:
##########
@@ -221,7 +222,7 @@ class SliceAdder extends React.Component {
innerRef={dragSourceRef}
style={style}
sliceName={cellData.slice_name}
- lastModified={cellData.changed_on_humanized}
+ lastModified={moment.utc(cellData.changed_on).fromNow()}
Review Comment:
changed_on_humanized have any translation. I will be glade to keep 'changed_on_humanized' but what I can change to have transaltion on it
I move the change on this PR : https://github.com/apache/superset/pull/20082
we can discuss about that on the new PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on a diff in pull request #20061: fix: Add french translation missing
Posted by GitBox <gi...@apache.org>.
aehanno commented on code in PR #20061:
URL: https://github.com/apache/superset/pull/20061#discussion_r873829467
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -314,7 +314,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
<Divider />
<div>
<div className="section-title">{t('Actual time range')}</div>
- {validTimeRange && <div>{evalResponse}</div>}
+ {validTimeRange && <div>{t(evalResponse)}</div>}
Review Comment:
change has been move in this PR : https://github.com/apache/superset/pull/20080
We can discuss about translation of varaible in the ohter PR
Without the t() here, there is no translation, do you have an idea, where I can translate this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org