You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "KhushJain (via GitHub)" <gi...@apache.org> on 2026/06/06 22:58:34 UTC
[PR] SOLR-18221 Add support for percentile in rollup for streaming expressions [solr]
KhushJain opened a new pull request, #4504:
URL: https://github.com/apache/solr/pull/4504
https://issues.apache.org/jira/browse/SOLR-18221
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Added support for `per(col, percentile)` metric in `rollup()` streaming expressions.
The `per(col, percentile)` metric in `rollup()` streaming expressions was non-functional; the `PercentileMetric` class was a stub copy-pasted from `MaxMetric` that returned garbage values.
# Solution
Implemented `PercentileMetric` using T-Digest (`AVLTreeDigest`, compression=100), matching the server-side `PercentileAgg` used by `facet()` and `stats()`. Supports decimal percentiles (e.g., `per(a_i, 99.9)`).
# Tests
`testPercentileRollupStream`: validates `per()` with multiple percentiles (0, 50, 99.9, 100)
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
- [x] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18221 Add support for percentile in rollup for streaming expressions [solr]
Posted by "KhushJain (via GitHub)" <gi...@apache.org>.
KhushJain commented on PR #4504:
URL: https://github.com/apache/solr/pull/4504#issuecomment-4674820125
Yes please! @epugh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18221 Add support for percentile in rollup for streaming expressions [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4504:
URL: https://github.com/apache/solr/pull/4504#issuecomment-4675625483
okay, I am going back to branch_9x, and I believe that when we restart the 9.11 release process, branch_9x will be merged in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18221 Add support for percentile in rollup for streaming expressions [solr]
Posted by "KhushJain (via GitHub)" <gi...@apache.org>.
KhushJain commented on PR #4504:
URL: https://github.com/apache/solr/pull/4504#issuecomment-4661703565
The existing test in solr core seems to be failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18221 Add support for percentile in rollup for streaming expressions [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4504:
URL: https://github.com/apache/solr/pull/4504#issuecomment-4673892909
> @KhushJain are we backporting all the way to branch_9x and branch_9_11?
Looks like it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18221 Add support for percentile in rollup for streaming expressions [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4504:
URL: https://github.com/apache/solr/pull/4504#issuecomment-4673884911
@KhushJain are we backporting all the way to branch_9x and branch_9_11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18221 Add support for percentile in rollup for streaming expressions [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #4504:
URL: https://github.com/apache/solr/pull/4504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18221 Add support for percentile in rollup for streaming expressions [solr]
Posted by "KhushJain (via GitHub)" <gi...@apache.org>.
KhushJain commented on PR #4504:
URL: https://github.com/apache/solr/pull/4504#issuecomment-4660362742
@epugh Can you do the honors : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org