[jira] [Commented] (CASSANDRA-12982) Customizable hint ttl has been removed

["Aleksey Yeschenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957554#comment-15957554 ] 

Aleksey Yeschenko commented on CASSANDRA-12982:
-----------------------------------------------

bq. Someone reading HintsReader wouldn’t expect the method to behave that way, and there doesn’t seem to be any benefit to doing it that way. It’s slightly riskier, no faster, and approximately as understandable as just copying the bytes.

It might not be faster (though I expect it is), but it does create less garbage (one extra array, one extra byte buffer, and one {{DataInputBuffer}} in the original version) - and it is a regression for the common case (hint is live). If you reencode timestamp and gcgs, you are no worse than before, allocation-wise. I might open a JIRA later to address this, but I guess it'll do for now - hint replay is not on the hot path.

I made some very minor cosmetic changes on top of you branch - which aren't really necessary, but if you don't mind, I'll be a tiny bit happier if they make it in. Links:

||branch||testall||dtest||
|[12982-3.11|https://github.com/iamaleksey/cassandra/tree/12982-3.11]|[testall|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-12982-3.11-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-12982-3.11-dtest]|
|[12982-trunk|https://github.com/iamaleksey/cassandra/tree/12982-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-12982-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-12982-trunk-dtest]|

With or without these, LGTM.

> Customizable hint ttl has been removed
> --------------------------------------
>
>                 Key: CASSANDRA-12982
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12982
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 3.11.x
>
>
> The cassandra.maxHintTTL property added in CASSANDRA-5988 was removed in the hint system rewrite for 3.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)