[GitHub] [spark] gengliangwang commented on a change in pull request #35260: [MINOR][SPARK-35028][SPARK-37533][FOLLOWUP] Remove useless code in Analyzer and TryEvalSuite

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #35260:
URL: https://github.com/apache/spark/pull/35260#discussion_r788782776



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1879,9 +1879,6 @@ class Analyzer(override val catalogManager: CatalogManager)
       }}
     }
 
-    // Group by alias is not allowed in ANSI mode.
-    private def allowGroupByAlias: Boolean = conf.groupByAliases && !conf.ansiEnabled

Review comment:
       Somehow this one is missed in https://github.com/apache/spark/commit/8bfb4f1e72.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org