You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "DarvenDuan (via GitHub)" <gi...@apache.org> on 2024/06/17 09:02:35 UTC

[PR] [fix](restore) avoid NPE for restore job [doris]

DarvenDuan opened a new pull request, #36395:
URL: https://github.com/apache/doris/pull/36395

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) avoid NPE for restore job [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36395:
URL: https://github.com/apache/doris/pull/36395#issuecomment-2191686187

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.3 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 85fbb2665ce44a6e31ba6917d47568a01ba75b55, data reload: false
   
   query1	0.04	0.04	0.03
   query2	0.08	0.04	0.04
   query3	0.22	0.05	0.05
   query4	1.68	0.08	0.08
   query5	0.50	0.50	0.49
   query6	1.14	0.73	0.72
   query7	0.02	0.01	0.02
   query8	0.05	0.04	0.04
   query9	0.54	0.49	0.49
   query10	0.54	0.53	0.54
   query11	0.14	0.11	0.12
   query12	0.15	0.12	0.13
   query13	0.60	0.59	0.61
   query14	0.80	0.78	0.78
   query15	0.83	0.81	0.81
   query16	0.36	0.35	0.35
   query17	0.98	0.96	0.99
   query18	0.22	0.24	0.23
   query19	1.80	1.68	1.71
   query20	0.01	0.02	0.01
   query21	15.44	0.76	0.65
   query22	4.26	7.66	1.64
   query23	18.25	1.32	1.28
   query24	2.14	0.22	0.23
   query25	0.15	0.08	0.09
   query26	0.27	0.18	0.17
   query27	0.08	0.08	0.08
   query28	13.20	1.03	1.00
   query29	12.56	3.36	3.31
   query30	0.25	0.06	0.05
   query31	2.88	0.39	0.39
   query32	3.26	0.48	0.47
   query33	2.91	2.87	2.98
   query34	17.08	4.42	4.38
   query35	4.47	4.51	4.54
   query36	0.65	0.47	0.49
   query37	0.17	0.15	0.16
   query38	0.15	0.15	0.15
   query39	0.04	0.03	0.04
   query40	0.16	0.15	0.15
   query41	0.09	0.06	0.05
   query42	0.06	0.04	0.04
   query43	0.04	0.04	0.04
   Total cold run time: 109.26 s
   Total hot run time: 30.3 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) avoid NPE for restore job [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36395:
URL: https://github.com/apache/doris/pull/36395#issuecomment-2172745166

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) avoid NPE for restore job [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #36395:
URL: https://github.com/apache/doris/pull/36395#issuecomment-2191549514

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) avoid NPE for restore job [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36395:
URL: https://github.com/apache/doris/pull/36395#issuecomment-2191643990

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 39668 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 85fbb2665ce44a6e31ba6917d47568a01ba75b55, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17608	4352	4285	4285
   q2	2013	193	194	193
   q3	10437	1234	996	996
   q4	10187	809	739	739
   q5	7467	2639	2636	2636
   q6	213	132	137	132
   q7	950	590	598	590
   q8	9235	2059	2064	2059
   q9	8949	6507	6421	6421
   q10	9031	3736	3738	3736
   q11	442	240	233	233
   q12	475	244	229	229
   q13	17949	3030	3040	3030
   q14	260	233	213	213
   q15	526	474	487	474
   q16	507	377	380	377
   q17	958	690	778	690
   q18	8184	7593	7403	7403
   q19	7983	1471	1425	1425
   q20	664	309	328	309
   q21	5011	3159	3171	3159
   q22	405	339	341	339
   Total cold run time: 119454 ms
   Total hot run time: 39668 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4507	4306	4308	4306
   q2	378	261	264	261
   q3	3090	2950	2970	2950
   q4	1941	1739	1732	1732
   q5	5587	5628	5640	5628
   q6	229	140	133	133
   q7	2372	1995	1977	1977
   q8	3367	3505	3515	3505
   q9	8927	9048	9009	9009
   q10	4283	3782	3874	3782
   q11	611	512	510	510
   q12	870	655	626	626
   q13	16226	3250	3207	3207
   q14	321	284	282	282
   q15	541	488	496	488
   q16	476	440	443	440
   q17	1840	1527	1513	1513
   q18	8116	7822	7838	7822
   q19	1791	1617	1483	1483
   q20	2191	1905	1875	1875
   q21	8918	4890	4785	4785
   q22	616	569	541	541
   Total cold run time: 77198 ms
   Total hot run time: 56855 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) avoid NPE for restore job [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36395:
URL: https://github.com/apache/doris/pull/36395#issuecomment-2191550416

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) avoid NPE for restore job [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36395:
URL: https://github.com/apache/doris/pull/36395#issuecomment-2191671854

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 174191 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 85fbb2665ce44a6e31ba6917d47568a01ba75b55, data reload: false
   
   query1	922	385	374	374
   query2	6446	2393	2419	2393
   query3	6633	206	218	206
   query4	20757	17467	17157	17157
   query5	3704	474	496	474
   query6	239	172	161	161
   query7	4575	300	287	287
   query8	302	278	306	278
   query9	8531	2458	2432	2432
   query10	575	309	275	275
   query11	10470	9980	9919	9919
   query12	112	85	81	81
   query13	1645	369	374	369
   query14	9607	7768	7646	7646
   query15	249	183	183	183
   query16	8045	279	270	270
   query17	1892	561	504	504
   query18	2052	277	267	267
   query19	186	146	146	146
   query20	87	80	81	80
   query21	209	135	125	125
   query22	4301	4267	4001	4001
   query23	34084	33615	33746	33615
   query24	10751	3022	2821	2821
   query25	577	408	363	363
   query26	705	156	154	154
   query27	2268	325	325	325
   query28	6075	2177	2171	2171
   query29	869	659	627	627
   query30	248	161	153	153
   query31	1016	766	774	766
   query32	97	61	57	57
   query33	642	289	310	289
   query34	889	475	485	475
   query35	749	648	643	643
   query36	1117	950	970	950
   query37	145	74	75	74
   query38	2967	2867	2796	2796
   query39	917	853	824	824
   query40	209	135	127	127
   query41	53	54	56	54
   query42	112	96	109	96
   query43	606	549	536	536
   query44	1083	741	727	727
   query45	195	170	170	170
   query46	1083	718	740	718
   query47	1882	1797	1771	1771
   query48	371	302	306	302
   query49	834	398	405	398
   query50	771	387	392	387
   query51	6953	6851	6807	6807
   query52	107	97	92	92
   query53	369	292	291	291
   query54	889	438	435	435
   query55	74	74	72	72
   query56	273	260	260	260
   query57	1139	1012	1046	1012
   query58	233	241	253	241
   query59	3311	3095	3149	3095
   query60	294	272	279	272
   query61	89	86	91	86
   query62	608	454	459	454
   query63	309	286	290	286
   query64	8554	2208	1761	1761
   query65	3173	3113	3090	3090
   query66	748	319	328	319
   query67	15405	14856	14926	14856
   query68	4899	532	542	532
   query69	635	479	396	396
   query70	1184	1105	1146	1105
   query71	474	273	269	269
   query72	7076	5416	5649	5416
   query73	776	325	321	321
   query74	5868	5510	5504	5504
   query75	3658	2645	2712	2645
   query76	3592	980	915	915
   query77	602	299	300	299
   query78	10341	9960	9697	9697
   query79	2537	566	508	508
   query80	1934	468	466	466
   query81	591	230	219	219
   query82	1430	103	100	100
   query83	335	166	170	166
   query84	274	85	84	84
   query85	1385	276	263	263
   query86	485	324	331	324
   query87	3283	3061	3047	3047
   query88	4324	2466	2439	2439
   query89	470	383	390	383
   query90	1733	190	186	186
   query91	127	98	99	98
   query92	60	49	49	49
   query93	2336	501	495	495
   query94	1124	189	182	182
   query95	402	306	318	306
   query96	588	275	268	268
   query97	3231	3077	3029	3029
   query98	238	195	185	185
   query99	1304	852	849	849
   Total cold run time: 272678 ms
   Total hot run time: 174191 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) avoid NPE for restore job [doris]

Posted by "DarvenDuan (via GitHub)" <gi...@apache.org>.
DarvenDuan commented on PR #36395:
URL: https://github.com/apache/doris/pull/36395#issuecomment-2174880826

   > Please describe when the case happens.
   
   I added some words in comment above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) avoid NPE for restore job [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36395:
URL: https://github.com/apache/doris/pull/36395#issuecomment-2191550354

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org