You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/17 09:53:00 UTC
[jira] [Commented] (FLINK-7814) Add BETWEEN and NOT BETWEEN
expression to Table API
[ https://issues.apache.org/jira/browse/FLINK-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478818#comment-16478818 ]
ASF GitHub Bot commented on FLINK-7814:
---------------------------------------
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188895939
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarOperatorsTest.scala ---
@@ -406,5 +406,26 @@ class ScalarOperatorsTest extends ScalarOperatorsTestBase {
"((((true) === true) || false).cast(STRING) + 'X ').trim",
"trueX")
testTableApi(12.isNull, "12.isNull", "false")
+
--- End diff --
I think we can use a separate test method for `Between`. Besides, some validation tests can be added to `org.apache.flink.table.expressions.validation.ScalarOperatorsValidationTest`.
> Add BETWEEN and NOT BETWEEN expression to Table API
> ---------------------------------------------------
>
> Key: FLINK-7814
> URL: https://issues.apache.org/jira/browse/FLINK-7814
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Fabian Hueske
> Assignee: Ruidong Li
> Priority: Minor
>
> * The Table API does not have a BETWEEN expression. BETWEEN is quite handy when defining join predicates for window joins.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)