You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/02 22:57:45 UTC
[GitHub] [helix] kaisun2000 opened a new pull request #1432: Enhancement of ClusterVerifier and TaskDriver #1431
kaisun2000 opened a new pull request #1432:
URL: https://github.com/apache/helix/pull/1432
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fix #1431
fix clusterVerifier to take waitTillVeriy and also enhance
logging of TaskDriver and TaskUtil to make sure the job
adding and selective update race condition would have a
log
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
Running
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- [ ] The following is the result of the "mvn test" command on the appropriate module:
running
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on a change in pull request #1432: Enhancement of ClusterVerifier and TaskDriver #1431
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on a change in pull request #1432:
URL: https://github.com/apache/helix/pull/1432#discussion_r499951091
##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -78,8 +78,8 @@
*/
@Deprecated
public BestPossibleExternalViewVerifier(String zkAddr, String clusterName, Set<String> resources,
- Map<String, Map<String, String>> errStates, Set<String> expectLiveInstances) {
- super(zkAddr, clusterName);
+ Map<String, Map<String, String>> errStates, Set<String> expectLiveInstances, int waitTillVerify) {
Review comment:
Good point, let me do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on a change in pull request #1432: Enhancement of ClusterVerifier and TaskDriver #1431
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on a change in pull request #1432:
URL: https://github.com/apache/helix/pull/1432#discussion_r499951005
##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -78,8 +78,8 @@
*/
@Deprecated
public BestPossibleExternalViewVerifier(String zkAddr, String clusterName, Set<String> resources,
- Map<String, Map<String, String>> errStates, Set<String> expectLiveInstances) {
- super(zkAddr, clusterName);
+ Map<String, Map<String, String>> errStates, Set<String> expectLiveInstances, int waitTillVerify) {
Review comment:
This is good point.
In fact, we already added them in the builder. See this pull, https://github.com/apache/helix/pull/1328/files
The thing is that in pull 1328, we missed some places which is addressed in this pull.
The big pull #1227 validated that all missing ones are all addressed here. No more missing ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on a change in pull request #1432: Enhancement of ClusterVerifier and TaskDriver #1431
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on a change in pull request #1432:
URL: https://github.com/apache/helix/pull/1432#discussion_r499953917
##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -78,8 +78,8 @@
*/
@Deprecated
public BestPossibleExternalViewVerifier(String zkAddr, String clusterName, Set<String> resources,
- Map<String, Map<String, String>> errStates, Set<String> expectLiveInstances) {
- super(zkAddr, clusterName);
+ Map<String, Map<String, String>> errStates, Set<String> expectLiveInstances, int waitTillVerify) {
Review comment:
This is added.
```
/**
* The class of verify() methods in this class and its subclass such as
* BestPossibleExternalViewVerifier is intend to wait for the cluster converging to a stable
* state after changes in the cluster. However, after making changes, it would take some time
* till controller taking the changes in. Thus, if we verify() too early, before controller
* taking the changes, the class may mistake the previous stable cluster state as new (expected)
* stable state. This would cause various issues. Thus, we supply a waitPeriod before starting
* to validate next expected state to avoid this pre-mature stable state validation.
*/
public B setWaitTillVerify(int waitPeriod) {
_waitPeriodTillVerify = waitPeriod;
return (B) this;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on a change in pull request #1432: Enhancement of ClusterVerifier and TaskDriver #1431
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on a change in pull request #1432:
URL: https://github.com/apache/helix/pull/1432#discussion_r499938545
##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -78,8 +78,8 @@
*/
@Deprecated
public BestPossibleExternalViewVerifier(String zkAddr, String clusterName, Set<String> resources,
- Map<String, Map<String, String>> errStates, Set<String> expectLiveInstances) {
- super(zkAddr, clusterName);
+ Map<String, Map<String, String>> errStates, Set<String> expectLiveInstances, int waitTillVerify) {
Review comment:
Could you please add some doc about the rationale of adding waiting time?
##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -78,8 +78,8 @@
*/
@Deprecated
public BestPossibleExternalViewVerifier(String zkAddr, String clusterName, Set<String> resources,
- Map<String, Map<String, String>> errStates, Set<String> expectLiveInstances) {
- super(zkAddr, clusterName);
+ Map<String, Map<String, String>> errStates, Set<String> expectLiveInstances, int waitTillVerify) {
Review comment:
Note that these constructors are deprecated and suggest to use builder. So you may also want to add this new parameter to the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on pull request #1432: Enhancement of ClusterVerifier and TaskDriver #1431
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on pull request #1432:
URL: https://github.com/apache/helix/pull/1432#issuecomment-703974505
This pull request is approved. Please help to merge in to master.
>Fix #1431
fix clusterVerifier to take waitTillVeriy and also enhance
logging of TaskDriver and TaskUtil to make sure the job
adding and selective update race condition would have a
log
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm merged pull request #1432: Enhancement of ClusterVerifier and TaskDriver
Posted by GitBox <gi...@apache.org>.
pkuwm merged pull request #1432:
URL: https://github.com/apache/helix/pull/1432
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org