You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2021/07/01 05:15:00 UTC
[jira] [Commented] (SOLR-15124) Remove node/container level admin
handlers from ImplicitPlugins.json (core level).
[ https://issues.apache.org/jira/browse/SOLR-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372389#comment-17372389 ]
David Smiley commented on SOLR-15124:
-------------------------------------
I'd guess that would leave these handlers without any tests? (clearly not what we want)
> Remove node/container level admin handlers from ImplicitPlugins.json (core level).
> ----------------------------------------------------------------------------------
>
> Key: SOLR-15124
> URL: https://issues.apache.org/jira/browse/SOLR-15124
> Project: Solr
> Issue Type: Task
> Reporter: David Smiley
> Priority: Blocker
> Labels: newdev
> Fix For: main (9.0)
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> There are many very old administrative RequestHandlers registered in a SolrCore that are actually JVM / node / CoreContainer level in nature. These pre-dated CoreContainer level handlers. We should (1) remove them from ImplictPlugins.json, and (2) make simplifying tweaks to them to remove that they work at the core level. For example LoggingHandler has two constructors and a non-final Watcher because it works in these two modalities. It need only have the one that takes a CoreContainer, and Watcher will then be final.
> /admin/threads
> /admin/properties
> /admin/logging
> Should stay because has core-level stuff:
> /admin/plugins
> /admin/mbeans
> This one:
> /admin/system -- SystemInfoHandler
> returns "core" level information, and also node level stuff. I propose splitting this one to a CoreInfoHandler to split the logic. Maybe a separate issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org