[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a change in pull request #186: [Security] Workaround for CVE-2021-44228 Log4J RCE when Log4J >= 2.10.0

[GitBox <gi...@apache.org>]

michaeljmarshall commented on a change in pull request #186:
URL: https://github.com/apache/pulsar-helm-chart/pull/186#discussion_r766810762



##########
File path: charts/pulsar/templates/autorecovery-statefulset.yaml
##########
@@ -139,7 +139,7 @@ spec:
         - >
           bin/apply-config-from-env.py conf/bookkeeper.conf;
           {{- include "pulsar.autorecovery.zookeeper.tls.settings" . | nindent 10 }}
-          exec bin/bookkeeper autorecovery
+          OPTS="${OPTS} -Dlog4j2.formatMsgNoLookups=true" exec bin/bookkeeper autorecovery

Review comment:
       I was going to suggest that we update an argument elsewhere in a configmap, but by changing it this way, we guarantee that all users get this JVM arg.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org