You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/05/27 05:04:16 UTC
[GitHub] [james-project] quantranhong1999 opened a new pull request #458: JAMES-3516 Using the MessageResult::getThreadId property at the JMAP level
quantranhong1999 opened a new pull request #458:
URL: https://github.com/apache/james-project/pull/458
Using the MessageResult::getThreadId property at the JMAP level - in Email/get + Email/import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #458: JAMES-3516 Using the MessageResult::getThreadId property at the JMAP level
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #458:
URL: https://github.com/apache/james-project/pull/458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #458: JAMES-3516 Using the MessageResult::getThreadId property at the JMAP level
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #458:
URL: https://github.com/apache/james-project/pull/458#discussion_r640294881
##########
File path: mailbox/api/src/main/java/org/apache/james/mailbox/model/ThreadId.java
##########
@@ -35,6 +35,10 @@ public MessageId getBaseMessageId() {
return baseMessageId;
}
+ public String serialize() {
+ return baseMessageId.serialize();
Review comment:
Can we have at least one unit test for this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #458: JAMES-3516 Using the MessageResult::getThreadId property at the JMAP level
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #458:
URL: https://github.com/apache/james-project/pull/458#discussion_r640290783
##########
File path: server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/Email.scala
##########
@@ -421,6 +420,7 @@ private class EmailMetadataViewFactory @Inject()(zoneIdProvider: ZoneIdProvider)
val mailboxIds: MailboxIds = MailboxIds(message._2
.map(_.getMailboxId)
.toList)
+ val threadId: ThreadId = ThreadId(message._2.head.getThreadId.getBaseMessageId.serialize())
Review comment:
We should not expose at the JMAP level `getBaseMessageId` which is an implementation detail.
We should have a `ThreadId::serialize` method IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org