[GitHub] [airflow] yourhiro opened a new pull request #5111: [AIRFLOW-4294] fix missing dag & task runs in UI when . in dag_id

[GitBox <gi...@apache.org>]

yourhiro opened a new pull request #5111: [AIRFLOW-4294] fix missing dag & task runs in UI when . in dag_id
URL: https://github.com/apache/airflow/pull/5111
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4294
     - https://issues.apache.org/jira/browse/AIRFLOW-4325
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   This fixes a regression when a dag_id has a '.' character in its name. The new UI uses "safe" dag_ids for the IDs of the corresponding DOM elements and when the endpoint `/dag_stats` returns the payload keyed on the regular dag_id, d3 is unable to update the elements.
   
   The fix is to convert the dag_ids in the payload to a 'safe' dag_id by replacing all the `.` characters with `__dot__` so the relevant DOM elements can be selected and updated
   
   Before:
   ![airflow 1 10 3 missing task and dag runs](https://user-images.githubusercontent.com/17157/56182011-eadb9a80-5fc4-11e9-8476-2b898b0bb02f.png)
   
   After change:
   ![task and dag runs fix](https://user-images.githubusercontent.com/17157/56182016-f29b3f00-5fc4-11e9-8894-9a16207ca829.png)
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   Manual testing confirms that it show dag runs and task runs correctly
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   **N/A**
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
   **N/A**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services