You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/28 09:27:14 UTC
[GitHub] [dolphinscheduler] DingPengfei opened a new issue, #9836: [Bug] [dolphinscheduler-ui-next] parameter check of subprocess is invalid
DingPengfei opened a new issue, #9836:
URL: https://github.com/apache/dolphinscheduler/issues/9836
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Creating a process which has subprocess node in will get parameter invalid.
I found that the json sent by fontend has the key "processDefinitionId", but backend is using "processDenifitionCode"
[https://github.com/apache/dolphinscheduler/blob/6a2484196ddcb5c87c75e4fe8414d178c2ef4882/dolphinscheduler-task-plugin/dolphinscheduler-task-subprocess/src/main/java/org/apache/dolphinscheduler/plugin/task/subprocess/SubProcessTaskChannel.java#L43](url)
`return JSONUtils.parseObject(parametersNode.getTaskParams(), SubProcessParameters.class);`
code here will gives processDenifitionCode a default value
I think the json key from frontend should be "processDenifitionCode"
### What you expected to happen
Creating process successfully
### How to reproduce
Just create a process contains subprocess
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] labbomb commented on issue #9836: [Bug] [dolphinscheduler-ui-next] parameter check of subprocess is invalid
Posted by GitBox <gi...@apache.org>.
labbomb commented on issue #9836:
URL: https://github.com/apache/dolphinscheduler/issues/9836#issuecomment-1112804329
>
I cannot reproduce this problem according to the steps you provided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #9836: [Bug] [dolphinscheduler-ui-next] parameter check of subprocess is invalid
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #9836:
URL: https://github.com/apache/dolphinscheduler/issues/9836#issuecomment-1112037881
Hi @DingPengfei , can you describe the steps to reproduce this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DingPengfei closed issue #9836: [Bug] [dolphinscheduler-ui-next] parameter check of subprocess is invalid
Posted by GitBox <gi...@apache.org>.
DingPengfei closed issue #9836: [Bug] [dolphinscheduler-ui-next] parameter check of subprocess is invalid
URL: https://github.com/apache/dolphinscheduler/issues/9836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] labbomb commented on issue #9836: [Bug] [dolphinscheduler-ui-next] parameter check of subprocess is invalid
Posted by GitBox <gi...@apache.org>.
labbomb commented on issue #9836:
URL: https://github.com/apache/dolphinscheduler/issues/9836#issuecomment-1112804453
>  @SbloodyS @labbomb here it is
>
> 1. Creating a process named A
> 2. Creating a process B contains a subprocess node within process a
> 3. When you save process B, this issue occurs
I cannot reproduce this problem according to the steps you provided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DingPengfei commented on issue #9836: [Bug] [dolphinscheduler-ui-next] parameter check of subprocess is invalid
Posted by GitBox <gi...@apache.org>.
DingPengfei commented on issue #9836:
URL: https://github.com/apache/dolphinscheduler/issues/9836#issuecomment-1112795231
@SbloodyS @labbomb here it is
1. Creating a process named A
2. Creating a process B contains a subprocess node within process a
3. When you save process B, this issue occurs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #9836: [Bug] [dolphinscheduler-ui-next] parameter check of subprocess is invalid
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #9836:
URL: https://github.com/apache/dolphinscheduler/issues/9836#issuecomment-1111970352
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://join.slack.com/t/asf-dolphinscheduler/shared_invite/zt-omtdhuio-_JISsxYhiVsltmC5h38yfw) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Amy0104 commented on issue #9836: [Bug] [dolphinscheduler-ui-next] parameter check of subprocess is invalid
Posted by GitBox <gi...@apache.org>.
Amy0104 commented on issue #9836:
URL: https://github.com/apache/dolphinscheduler/issues/9836#issuecomment-1112804603
<img width="779" alt="image" src="https://user-images.githubusercontent.com/97265214/165872812-b5a9c604-3bbf-4d89-a830-7b6b6bcf9b8b.png">
The front-end input field is "processDenifitionCode" not "processDefinitionId". Please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DingPengfei commented on issue #9836: [Bug] [dolphinscheduler-ui-next] parameter check of subprocess is invalid
Posted by GitBox <gi...@apache.org>.
DingPengfei commented on issue #9836:
URL: https://github.com/apache/dolphinscheduler/issues/9836#issuecomment-1112824207
I made a mistake, sorry for taking up your time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] labbomb commented on issue #9836: [Bug] [dolphinscheduler-ui-next] parameter check of subprocess is invalid
Posted by GitBox <gi...@apache.org>.
labbomb commented on issue #9836:
URL: https://github.com/apache/dolphinscheduler/issues/9836#issuecomment-1112038600
@DingPengfei Can you provide screenshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org