You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2018/03/05 15:28:00 UTC
[jira] [Commented] (HIVE-18859) Incorrect handling of thrift
metastore exceptions
[ https://issues.apache.org/jira/browse/HIVE-18859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386206#comment-16386206 ]
Hive QA commented on HIVE-18859:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12913032/HIVE-18859.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9488/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9488/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9488/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-03-05 15:25:28.008
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-9488/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-03-05 15:25:28.012
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 05d4719 HIVE-18833: Auto Merge fails when "insert into directory as orcfile" (Daniel Dai, reviewed by Prasanth Jayachandran)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 05d4719 HIVE-18833: Auto Merge fails when "insert into directory as orcfile" (Daniel Dai, reviewed by Prasanth Jayachandran)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-03-05 15:25:31.412
+ rm -rf ../yetus_PreCommit-HIVE-Build-9488
+ mkdir ../yetus_PreCommit-HIVE-Build-9488
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-9488
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-9488/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch
error: metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java: does not exist in index
error: src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java: does not exist in index
error: java/org/apache/hadoop/hive/metastore/HiveMetaStore.java: does not exist in index
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12913032 - PreCommit-HIVE-Build
> Incorrect handling of thrift metastore exceptions
> -------------------------------------------------
>
> Key: HIVE-18859
> URL: https://issues.apache.org/jira/browse/HIVE-18859
> Project: Hive
> Issue Type: Bug
> Affects Versions: 1.2.0, 2.1.1
> Reporter: Ganesha Shreedhara
> Assignee: Ganesha Shreedhara
> Priority: Major
> Attachments: HIVE-18859.patch
>
>
> Currently any run time exception thrown in thrift metastore during the following operations is not getting sent to hive execution engine.
> * grant/revoke role
> * grant/revoke privileges
> * create role
> This is because ThriftHiveMetastore just handles MetaException and throws TException during the processing of these requests. So, the command just fails at thrift metastore end when there is run time exception (Exception can be seen in metastore log) but the hive execution engine will keep on waiting for the response from thrift metatstore.
>
> Steps to reproduce this problem :
> Launch thrift metastore
> Launch hive cli by passing --hiveconf hive.metastore.uris=thrift://127.0.0.1:10000 (pass the thrift metatstore host and port)
> Execute the following commands:
> # set role admin
> # create role test; (succeeds)
> # create role test; ( hive version 2.1.1 : command is stuck, waiting for the response from thrift metastore; hive version 1.2.1: command fails with exception as null)
>
> I have uploaded the patch which has the fix in which I am handling the checked exceptions in MetaException and throwing unchecked exceptions using TException which fixes the problem. Please review and suggest if there is a better way of handling this issue.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)