You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by SrikanteswaraRao Talluri <sr...@citrix.com> on 2013/05/14 16:41:59 UTC

Review Request: Fix test_volumes.py for BVT failures

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11153/
-----------------------------------------------------------

Review request for cloudstack and Prasanna Santhanam.


Description
-------

Fix test_volumes.py for BVT failures in the resize volume test and deletedetached volume test.
Added basic zone tags to the tests


This addresses bug CLOUDSTACK-2478.


Diffs
-----

  test/integration/smoke/test_volumes.py 4bf8203 

Diff: https://reviews.apache.org/r/11153/diff/


Testing
-------

tested


Thanks,

SrikanteswaraRao Talluri


Re: Review Request: Fix test_volumes.py for BVT failures

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11153/#review20691
-----------------------------------------------------------

Ship it!


55d304a5bbca27994c01c0f7c63b6168d2a90f60

- Prasanna Santhanam


On May 15, 2013, 5:01 p.m., SrikanteswaraRao Talluri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11153/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 5:01 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> -------
> 
> Fix test_volumes.py for BVT failures in the resize volume test and deletedetached volume test.
> Added basic zone tags to the tests
> 
> 
> This addresses bug CLOUDSTACK-2478.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_volumes.py 4bf8203 
> 
> Diff: https://reviews.apache.org/r/11153/diff/
> 
> 
> Testing
> -------
> 
> tested
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>


Re: Review Request: Fix test_volumes.py for BVT failures

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11153/
-----------------------------------------------------------

(Updated May 15, 2013, 5:01 p.m.)


Review request for cloudstack and Prasanna Santhanam.


Changes
-------

squashed all the commits into one and uploaded the diff


Description
-------

Fix test_volumes.py for BVT failures in the resize volume test and deletedetached volume test.
Added basic zone tags to the tests


This addresses bug CLOUDSTACK-2478.


Diffs (updated)
-----

  test/integration/smoke/test_volumes.py 4bf8203 

Diff: https://reviews.apache.org/r/11153/diff/


Testing
-------

tested


Thanks,

SrikanteswaraRao Talluri


Re: Review Request: Fix test_volumes.py for BVT failures

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11153/
-----------------------------------------------------------

(Updated May 15, 2013, 10:38 a.m.)


Review request for cloudstack and Prasanna Santhanam.


Changes
-------

Uploaded the diff with some more changes 


Description
-------

Fix test_volumes.py for BVT failures in the resize volume test and deletedetached volume test.
Added basic zone tags to the tests


This addresses bug CLOUDSTACK-2478.


Diffs (updated)
-----

  test/integration/smoke/test_volumes.py 4bf8203 

Diff: https://reviews.apache.org/r/11153/diff/


Testing
-------

tested


Thanks,

SrikanteswaraRao Talluri


Re: Review Request: Fix test_volumes.py for BVT failures

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.

> On May 15, 2013, 7:05 a.m., Prasanna Santhanam wrote:
> > I think the local storage tests were included to test for resize volume related functionality. Can you separate those tests? Perhaps into another suite? So we don't lose them.
> > 
> >

I have tested resize volume on shared storage, they passed. One needs to modify their test data whether to run on local storage or shared.


- SrikanteswaraRao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11153/#review20565
-----------------------------------------------------------


On May 15, 2013, 10:38 a.m., SrikanteswaraRao Talluri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11153/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 10:38 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> -------
> 
> Fix test_volumes.py for BVT failures in the resize volume test and deletedetached volume test.
> Added basic zone tags to the tests
> 
> 
> This addresses bug CLOUDSTACK-2478.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_volumes.py 4bf8203 
> 
> Diff: https://reviews.apache.org/r/11153/diff/
> 
> 
> Testing
> -------
> 
> tested
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>


Re: Review Request: Fix test_volumes.py for BVT failures

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11153/#review20565
-----------------------------------------------------------


I think the local storage tests were included to test for resize volume related functionality. Can you separate those tests? Perhaps into another suite? So we don't lose them.



- Prasanna Santhanam


On May 14, 2013, 2:41 p.m., SrikanteswaraRao Talluri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11153/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 2:41 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> -------
> 
> Fix test_volumes.py for BVT failures in the resize volume test and deletedetached volume test.
> Added basic zone tags to the tests
> 
> 
> This addresses bug CLOUDSTACK-2478.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_volumes.py 4bf8203 
> 
> Diff: https://reviews.apache.org/r/11153/diff/
> 
> 
> Testing
> -------
> 
> tested
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>