You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Enis Soztutar (JIRA)" <ji...@apache.org> on 2017/03/29 21:15:42 UTC
[jira] [Updated] (RATIS-52) Refactor RaftUtils into different
classes
[ https://issues.apache.org/jira/browse/RATIS-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated RATIS-52:
-------------------------------
Attachment: ratis-52_v1.patch
v1 patch. Mostly straightforward refactoring. Only change is some addition of more convenience methods in the ReflectionUtils needed by RATIS-40. Other than that no code change.
New classes:
IOUTils, Iterables, LogUtils, PlatformUtils, Preconditions, ReflectionUtils. RaftUtils is gone. Should we need RAFT (as in protocol-related) utility methods, we can re-add at a later time.
Appreciate if Nicolas or Jing can skim over the changes. It is a huge patch, I don't want to keep rebasing. Thanks.
> Refactor RaftUtils into different classes
> -----------------------------------------
>
> Key: RATIS-52
> URL: https://issues.apache.org/jira/browse/RATIS-52
> Project: Ratis
> Issue Type: Improvement
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: ratis-52_v1.patch
>
>
> Ideally we should not have a generic {{RaftUtils}} class. The code should be broken up into at least:
> {code}
> ReflectionUtils -> All reflection, construction, initialization logic
> IOUtils -> Add buffer and IO logic
> SystemUtils or PlatformUtils -> OS type detection, etc
> Preconditions (or something like that) -> assertTrue, etc
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)