[jira] [Commented] (THRIFT-1980) Modernize Go tooling, fix go client libary.

["Carl Yeksigian (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678053#comment-13678053 ] 

Carl Yeksigian commented on THRIFT-1980:
----------------------------------------

Jake, are you still reviewing this one?

                
> Modernize Go tooling, fix go client libary.
> -------------------------------------------
>
>                 Key: THRIFT-1980
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1980
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler, Go - Library
>    Affects Versions: 1.0
>            Reporter: Travis Cline
>         Attachments: 0001-THRIFT-1980-Go-Modernize-go-tooling.-Update-autoconf.patch, 0002-Integrate-changes-from-github.com-pomack-thrift4go.patch, 0003-Update-tutorial-code-for-go1.patch, 0004-Fix-imports-add-package-prefixes-configurable-thrift.patch, thrift4go-master.zip
>
>
> This patch improves some of the Go tooling to get it inline with modern (post-1.0) go development practices.
> As of go1 (go1.1 is current) 'gomake' et al are missing and Go code should be built and installed via the go tool. (see http://golang.org/cmd/go/)
> It removes the generated Makefiles as they are no longer used for go development.
> Along those lines, the patch also encourages the use of go get to install the go client library (currently pointing to the github mirror). Not using 'go get' is non-idiomatic for go development and we should support and encourage installing via go get.
> It also starts including running go tests as part of 'make check'.
> Patches:
> 0001-THRIFT-1980-Go-Modernize-go-tooling.-Update-autoconf.patch - initial patch to move away from makefiles and to encourage go get
> 0002-Integrate-changes-from-github.com-pomack-thrift4go.patch - update the client code from pomack's github fork (@ 4e1ad38)
> 0003-Update-tutorial-code-for-go1.patch - update tutorial/go code for go1
> 0004-Fix-imports-add-package-prefixes-configurable-thrift.patch - fix generated go code to not create additional, bad import statements
> This work is mirrored at https://github.com/traviscline/thrift

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira