[GitHub] ctubbsii commented on a change in pull request #316: ACCUMULO-4706 Updates to support Accumulo docker image

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #316: ACCUMULO-4706 Updates to support Accumulo docker image
URL: https://github.com/apache/accumulo/pull/316#discussion_r148323518
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java
 ##########
 @@ -119,8 +119,15 @@ synchronized private static Configuration getXmlConfig() {
 
   @Override
   public String get(Property property) {
-    String key = property.getKey();
+    return get(property, true);
+  }
 
+  public String get(Property property, boolean useDefault) {
 
 Review comment:
   I wouldn't bother creating a whole new layer on top of SiteConfiguration. SiteConfiguration is poorly named. It's really "Local Configuration" or "Startup Configuration". In any case, too much mucking with the configuration hierarchy could conflict with other efforts to clean up TableConfiguration and such.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services