You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pankajkoti (via GitHub)" <gi...@apache.org> on 2023/09/05 03:40:16 UTC
[GitHub] [airflow] pankajkoti commented on a diff in pull request #34089: Add Celery extra in Breeze when using CeleryExecutor and --use-airflow
pankajkoti commented on code in PR #34089:
URL: https://github.com/apache/airflow/pull/34089#discussion_r1315329248
##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -721,12 +721,23 @@ def enter_shell(**kwargs) -> RunCommandResult:
if shell_params.backend == "sqlite":
get_console().print(
- f"\n[warn]backend: sqlite is not "
+ f"\n[warning]backend: sqlite is not "
f"compatible with executor: {shell_params.executor}. "
f"Changing the executor to SequentialExecutor.\n"
)
shell_params.executor = "SequentialExecutor"
+ if (
+ shell_params.executor == "CeleryExecutor"
+ and shell_params.use_airflow_version
+ and not shell_params.airflow_extras
Review Comment:
Is it possible that the user has specified some airflow_extras but has not included celery in it? If yes, should we check that whether celery is not present and add that to the extras?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org