You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2002/04/18 23:39:45 UTC
cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve EditValveAction.java SaveSingleSignOnValveAction.java ValveUtil.java
manveen 02/04/18 14:39:45
Modified: webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve
EditValveAction.java
SaveSingleSignOnValveAction.java ValveUtil.java
Log:
fix for create valve
Revision Changes Path
1.3 +5 -5 jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/EditValveAction.java
Index: EditValveAction.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/EditValveAction.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- EditValveAction.java 16 Apr 2002 17:04:19 -0000 1.2
+++ EditValveAction.java 18 Apr 2002 21:39:45 -0000 1.3
@@ -1,7 +1,7 @@
/*
- * $Header: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/EditValveAction.java,v 1.2 2002/04/16 17:04:19 manveen Exp $
- * $Revision: 1.2 $
- * $Date: 2002/04/16 17:04:19 $
+ * $Header: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/EditValveAction.java,v 1.3 2002/04/18 21:39:45 manveen Exp $
+ * $Revision: 1.3 $
+ * $Date: 2002/04/18 21:39:45 $
*
* ====================================================================
*
@@ -92,7 +92,7 @@
* Valve </em> transactions, based on the type of Valve.
*
* @author Manveen Kaur
- * @version $Revision: 1.2 $ $Date: 2002/04/16 17:04:19 $
+ * @version $Revision: 1.3 $ $Date: 2002/04/18 21:39:45 $
*/
public class EditValveAction extends Action {
@@ -168,7 +168,7 @@
parent = request.getParameter("parent");
String valveType = null;
String attribute = null;
-
+
// Find what type of Valve this is
try {
attribute = "className";
1.4 +5 -5 jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/SaveSingleSignOnValveAction.java
Index: SaveSingleSignOnValveAction.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/SaveSingleSignOnValveAction.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- SaveSingleSignOnValveAction.java 12 Apr 2002 22:06:30 -0000 1.3
+++ SaveSingleSignOnValveAction.java 18 Apr 2002 21:39:45 -0000 1.4
@@ -1,7 +1,7 @@
/*
- * $Header: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/SaveSingleSignOnValveAction.java,v 1.3 2002/04/12 22:06:30 manveen Exp $
- * $Revision: 1.3 $
- * $Date: 2002/04/12 22:06:30 $
+ * $Header: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/SaveSingleSignOnValveAction.java,v 1.4 2002/04/18 21:39:45 manveen Exp $
+ * $Revision: 1.4 $
+ * $Date: 2002/04/18 21:39:45 $
*
* ====================================================================
*
@@ -89,7 +89,7 @@
* <em>Edit Valve</em> transactions for Single Sign On valve.
*
* @author Manveen Kaur
- * @version $Revision: 1.3 $ $Date: 2002/04/12 22:06:30 $
+ * @version $Revision: 1.4 $ $Date: 2002/04/18 21:39:45 $
*/
public final class SaveSingleSignOnValveAction extends Action {
@@ -159,7 +159,7 @@
return ValveUtil.
createValve(parent, valveType, response, request, mapping,
(ApplicationServlet) getServlet());
-
+
}
// Perform attribute updates as requested
1.5 +10 -8 jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/ValveUtil.java
Index: ValveUtil.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/ValveUtil.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- ValveUtil.java 18 Apr 2002 07:39:28 -0000 1.4
+++ ValveUtil.java 18 Apr 2002 21:39:45 -0000 1.5
@@ -1,7 +1,7 @@
/*
- * $Header: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/ValveUtil.java,v 1.4 2002/04/18 07:39:28 manveen Exp $
- * $Revision: 1.4 $
- * $Date: 2002/04/18 07:39:28 $
+ * $Header: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/ValveUtil.java,v 1.5 2002/04/18 21:39:45 manveen Exp $
+ * $Revision: 1.5 $
+ * $Date: 2002/04/18 21:39:45 $
*
* ====================================================================
*
@@ -94,7 +94,7 @@
* A utility class that contains methods common across valves.
*
* @author Manveen Kaur
- * @version $Revision: 1.4 $ $Date: 2002/04/18 07:39:28 $
+ * @version $Revision: 1.5 $ $Date: 2002/04/18 21:39:45 $
*/
public final class ValveUtil {
@@ -138,6 +138,7 @@
String objectName = DeleteLoggerAction.getObjectName(parent,
TomcatTreeBuilder.VALVE_TYPE);
+ String parentNodeName = parent;
ObjectName pname = new ObjectName(parent);
StringBuffer sb = new StringBuffer(pname.getDomain());
@@ -193,7 +194,7 @@
TreeControl control = (TreeControl)
session.getAttribute("treeControlTest");
if (control != null) {
- TreeControlNode parentNode = control.findNode(parent);
+ TreeControlNode parentNode = control.findNode(parentNodeName);
if (parentNode != null) {
String nodeLabel =
"Valve for " + parentNode.getLabel();
@@ -203,15 +204,16 @@
new TreeControlNode(vObjectName,
"folder_16_pad.gif",
nodeLabel,
- "EditValve.do?select=" +
- encodedName,
+ "EditValve.do?select=" + encodedName +
+ "&nodeLabel=" + URLEncoder.encode(nodeLabel) +
+ "&parent=" + URLEncoder.encode(parent),
"content",
true);
parentNode.addChild(childNode);
// FIXME - force a redisplay
} else {
servlet.log
- ("Cannot find parent node '" + parent + "'");
+ ("Cannot find parent node '" + parentNodeName + "'");
}
} else {
servlet.log
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>