You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/27 06:34:23 UTC
[GitHub] [shardingsphere] Pace2Car opened a new pull request, #21788: Change DistSQL keyword INSTANCE to COMPUTE NODE in documents & classes
Pace2Car opened a new pull request, #21788:
URL: https://github.com/apache/shardingsphere/pull/21788
For #21666.
Changes proposed in this pull request:
- Rename INSTANCE classes & Revise comments
- Revise documents
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [x] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #21788: Change DistSQL keyword INSTANCE to COMPUTE NODE in documents & classes
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #21788:
URL: https://github.com/apache/shardingsphere/pull/21788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #21788: Change DistSQL keyword INSTANCE to COMPUTE NODE in documents & classes
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #21788:
URL: https://github.com/apache/shardingsphere/pull/21788#discussion_r1006484533
##########
distsql/statement/src/main/java/org/apache/shardingsphere/distsql/parser/statement/ral/queryable/ShowComputeNodeInfoStatement.java:
##########
@@ -20,7 +20,7 @@
import org.apache.shardingsphere.distsql.parser.statement.ral.QueryableRALStatement;
/**
- * Show instance list statement.
+ * Show compute node info statement.
*/
-public final class ShowInstanceListStatement extends QueryableRALStatement {
+public final class ShowComputeNodeInfoStatement extends QueryableRALStatement {
Review Comment:
It may be `ShowComputeNodesStatement`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21788: Change DistSQL keyword INSTANCE to COMPUTE NODE in documents & classes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21788:
URL: https://github.com/apache/shardingsphere/pull/21788#issuecomment-1293126808
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21788?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21788](https://codecov.io/gh/apache/shardingsphere/pull/21788?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (66b90d0) into [master](https://codecov.io/gh/apache/shardingsphere/commit/addda23c7126da25e6fdf904dfc25c0e074c6fc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (addda23) will **decrease** coverage by `0.00%`.
> The diff coverage is `70.00%`.
```diff
@@ Coverage Diff @@
## master #21788 +/- ##
============================================
- Coverage 60.79% 60.79% -0.01%
Complexity 2446 2446
============================================
Files 4118 4118
Lines 57476 57478 +2
Branches 9693 9693
============================================
+ Hits 34944 34945 +1
Misses 19627 19627
- Partials 2905 2906 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ser/core/kernel/KernelDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/21788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL2NvcmUva2VybmVsL0tlcm5lbERpc3RTUUxTdGF0ZW1lbnRWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/schema/loader/common/SchemaTableNamesLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/21788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvbG9hZGVyL2NvbW1vbi9TY2hlbWFUYWJsZU5hbWVzTG9hZGVyLmphdmE=) | `58.06% <0.00%> (-3.23%)` | :arrow_down: |
| [.../loader/dialect/datatype/OracleDataTypeLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/21788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvbG9hZGVyL2RpYWxlY3QvZGF0YXR5cGUvT3JhY2xlRGF0YVR5cGVMb2FkZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...distsql/ral/updatable/LabelComputeNodeHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/21788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9MYWJlbENvbXB1dGVOb2RlSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...stsql/ral/updatable/UnlabelComputeNodeHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/21788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9VbmxhYmVsQ29tcHV0ZU5vZGVIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../queryable/ShowComputeNodeInfoStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmFsL2ltcGwvcXVlcnlhYmxlL1Nob3dDb21wdXRlTm9kZUluZm9TdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `40.00% <0.00%> (ø)` | |
| [.../queryable/ShowComputeNodeModeStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmFsL2ltcGwvcXVlcnlhYmxlL1Nob3dDb21wdXRlTm9kZU1vZGVTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `40.00% <0.00%> (ø)` | |
| [...mpl/queryable/ShowComputeNodesStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmFsL2ltcGwvcXVlcnlhYmxlL1Nob3dDb21wdXRlTm9kZXNTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `40.00% <0.00%> (ø)` | |
| [...mpl/updatable/AlterComputeNodeStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmFsL2ltcGwvdXBkYXRhYmxlL0FsdGVyQ29tcHV0ZU5vZGVTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `71.42% <ø> (ø)` | |
| [...mpl/updatable/LabelComputeNodeStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmFsL2ltcGwvdXBkYXRhYmxlL0xhYmVsQ29tcHV0ZU5vZGVTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `66.66% <ø> (ø)` | |
| ... and [15 more](https://codecov.io/gh/apache/shardingsphere/pull/21788/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org