You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/06/24 10:21:40 UTC
[GitHub] [incubator-openwhisk-client-js] chetanmeh commented on a change in
pull request #171: Default Node.js runtime changed from 6 to 10
chetanmeh commented on a change in pull request #171: Default Node.js runtime changed from 6 to 10
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/171#discussion_r296653130
##########
File path: test/integration/actions.test.js
##########
@@ -86,7 +86,7 @@ test('create, get and delete an action', t => {
}).then(result => {
t.is(result.name, 'random_action_test')
t.is(result.namespace, NAMESPACE)
- t.is(result.exec.kind, 'nodejs:6')
+ t.is(result.exec.kind, 'nodejs:10')
Review comment:
May be we just check if `kind` contains or starts with `nodejs`. Would make test more stable against future changes related to version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services