Re: [PR] GH-44555: [C++][Compute] Allow casting struct to bigger nullable struct [arrow]

["Tom-Newton (via GitHub)" <gi...@apache.org>]

Tom-Newton commented on code in PR #44587:
URL: https://github.com/apache/arrow/pull/44587#discussion_r1825696951


##########
cpp/src/arrow/dataset/scanner_test.cc:
##########
@@ -2328,7 +2328,7 @@ DatasetAndBatches MakeNestedDataset() {
       field("b", boolean()),
       field("c", struct_({
                      field("d", int64()),
-                     field("e", float64()),
+                     field("e", int64()),

Review Comment:
   I suspect this was not supposed to be different from in the physical schema. This data is used to test if a virtual column will be materialised so I guess it shouldn't be testing int64 -> float64 casting at the same time. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org