[GitHub] [accumulo] dlmarion commented on issue #3553: User initiated compactions that throw an exception may hang

["dlmarion (via GitHub)" <gi...@apache.org>]

dlmarion commented on issue #3553:
URL: https://github.com/apache/accumulo/issues/3553#issuecomment-1613052253

   I wrote a [test](https://github.com/dlmarion/accumulo/commit/c4110282a293387469a51ed98716af39d90fa161) that hangs.  On the Manager side, CompactionDriver.[isReady](https://github.com/apache/accumulo/blob/2.1/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java#L110) will continue to return a non-zero wait time as long as there are tablets which have a compactID that is less than the compactID for `this` compaction. For those tablets, the CompactionDriver continues to call TabletClientHandler.compact(), which goes through the motion each time of initiating a compaction on that tablet. 
   
   In InternalCompactionExecutor.InternalJob.[run](https://github.com/apache/accumulo/blob/2.1/server/tserver/src/main/java/org/apache/accumulo/tserver/compactions/InternalCompactionExecutor.java#L91) I cannot find anything that checks the FAILED status (or the COMPLETED status for that matter). A `completionCallback` is invoked (line 97) on success, but nothing happens on the failure path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org