[GitHub] [spark] beliefer commented on pull request #36726: [SPARK-39339][SQL] Support TimestampNTZ type in JDBC data source

[GitBox <gi...@apache.org>]

beliefer commented on PR #36726:
URL: https://github.com/apache/spark/pull/36726#issuecomment-1154735759

   > Thanks, merging to master
   
   I update this test case and it will fail !
   ```
     test("SPARK-37463: read/write Timestamp ntz to Orc with different time zone") {
       DateTimeTestUtils.withDefaultTimeZone(DateTimeTestUtils.LA) {
         val sqlText = """
                         |select
                         | timestamp_ntz '2021-06-01 00:00:00' ts_ntz1,
                         | timestamp_ntz '1883-11-16 00:00:00.0' as ts_ntz2,
                         | timestamp_ntz '2021-03-14 02:15:00.0' as ts_ntz3
                         |""".stripMargin
   
         withTempPath { dir =>
           val path = dir.getCanonicalPath
           val df = sql(sqlText)
   
           df.write.mode("overwrite").orc(path)
   
           val query = s"select * from `orc`.`$path`"
   
           DateTimeTestUtils.outstandingZoneIds.foreach { zoneId =>
             DateTimeTestUtils.withDefaultTimeZone(zoneId) {
               withAllNativeOrcReaders {
                 checkAnswer(sql(query), df)
               }
             }
           }
         }
       }
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org