[jira] [Commented] (HBASE-24295) [Chaos Monkey] abstract logging through the class hierarchy

["Hudson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-24295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170713#comment-17170713 ] 

Hudson commented on HBASE-24295:
--------------------------------

Results for branch branch-1
	[build #1337 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1337/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1337//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1337//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1337//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> [Chaos Monkey] abstract logging through the class hierarchy
> -----------------------------------------------------------
>
>                 Key: HBASE-24295
>                 URL: https://issues.apache.org/jira/browse/HBASE-24295
>             Project: HBase
>          Issue Type: Task
>          Components: integration tests
>    Affects Versions: 2.3.0
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0
>
>
> Running chaos monkey and watching the logs, it's very difficult to tell what actions are actually running. There's lots of shared methods through the class hierarchy that extends from {{abstract class Action}}, and each class comes with its own {{Logger}}. As a result, the logs have useless stuff like
> {noformat}
> INFO actions.Action: Started regionserver...
> {noformat}
> Add {{protected abstract Logger getLogger()}} to the class's internal interface, and have the concrete implementations provide their logger.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)