You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/07/06 14:01:15 UTC

[GitHub] [storm] agresch commented on a change in pull request #3295: STORM-3660: Remove use of queues for updating credentials

agresch commented on a change in pull request #3295:
URL: https://github.com/apache/storm/pull/3295#discussion_r450241225



##########
File path: storm-client/src/jvm/org/apache/storm/executor/Executor.java
##########
@@ -291,6 +294,22 @@ public void accept(Object event) {
         }
     }
 
+    public void setNeedToRefreshCreds() {
+        this.needToRefreshCreds = true;
+    }
+
+    protected void updateExecCredsIfRequired() {
+        if (this.needToRefreshCreds) {
+            this.needToRefreshCreds = false;
+            LOG.info("The credentials are being updated {}.", executorId);

Review comment:
       I think info should be fine.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org