You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/30 12:08:10 UTC
[GitHub] [spark] maropu commented on a change in pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
maropu commented on a change in pull request #31899:
URL: https://github.com/apache/spark/pull/31899#discussion_r604035533
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -219,9 +219,9 @@ ALTER TABLE table_identifier [ partition_spec ] SET LOCATION 'new_location'
Specifies the partition on which the property has to be set. Note that one can use a typed literal (e.g., date'2019-01-02') in the partition spec.
- **Syntax:** `PARTITION ( partition_col_name = partition_col_val [ , ... ] )`
+ **Syntax:** `PARTITION ( partition_col_name = partition_col_val [ , ... ] )`
-* **SERDEPROPERTIES ( key1 = val1, key2 = val2, ... )**
+* **SERDEPROPERTIES ( key1 [=] val1, key2 [=] val2, ... ) **
Review comment:
nit `) **` => `)**` (a unnecessary space?)
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -219,9 +219,9 @@ ALTER TABLE table_identifier [ partition_spec ] SET LOCATION 'new_location'
Specifies the partition on which the property has to be set. Note that one can use a typed literal (e.g., date'2019-01-02') in the partition spec.
- **Syntax:** `PARTITION ( partition_col_name = partition_col_val [ , ... ] )`
+ **Syntax:** `PARTITION ( partition_col_name = partition_col_val [ , ... ] )`
-* **SERDEPROPERTIES ( key1 = val1, key2 = val2, ... )**
+* **SERDEPROPERTIES ( key1 [=] val1, key2 [=] val2, ... ) **
Review comment:
nit `) **` => `)**` (a unnecessary change?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org