[jira] [Commented] (OPENNLP-1108) Default eos char addition causes backward compatbility problems

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072280#comment-16072280 ] 

ASF GitHub Bot commented on OPENNLP-1108:
-----------------------------------------

GitHub user kottmann opened a pull request:

    https://github.com/apache/opennlp/pull/242

    OPENNLP-1108: Set default eos char to null

    Thank you for contributing to Apache OpenNLP.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kottmann/opennlp opennlp-1108

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #242
    
----
commit 4ba702df7a994d6372951f90d8defe808b9a197a
Author: Jörn Kottmann <jo...@apache.org>
Date:   2017-07-03T11:24:41Z

    OPENNLP-1108: Set default eos char to null

----


> Default eos char addition causes backward compatbility problems
> ---------------------------------------------------------------
>
>                 Key: OPENNLP-1108
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1108
>             Project: OpenNLP
>          Issue Type: Bug
>          Components: Sentence Detector
>            Reporter: Joern Kottmann
>             Fix For: 1.8.1
>
>
> The addition of the \n as a default eos doesn't work well with existing models that don't contain a list of eos chars, and also doesn't work for users who train with defaults, because they now get different results.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)