You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/03/01 18:57:28 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #6595: Fix incorrect template strings

ocket8888 opened a new pull request #6595:
URL: https://github.com/apache/trafficcontrol/pull/6595


   This PR fixes an issue introduced in #6532 where some template strings use Javascript syntax like
   ```javascript
   `${variableName}`;
   ```
   but they should use Python syntax like
   ```python3
   f"{variable_name}"
   ```
   <hr/>
   
   ## Which Traffic Control components are affected by this PR?
   - GitHub Actions
   
   ## What is the best way to verify this PR?
   Run the GHA on your fork, verify the resulting PR
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   - master
   
   ## PR submission checklist
   - [ ] This PR has tests
   - [ ] This PR has documentation
   - [ ] This PR has a CHANGELOG.md entry
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman merged pull request #6595: Fix incorrect template strings

Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #6595:
URL: https://github.com/apache/trafficcontrol/pull/6595


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org