You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by felixalbani <gi...@git.apache.org> on 2018/03/14 14:52:04 UTC

[GitHub] zeppelin pull request #2867: ZEPPELIN-3332

GitHub user felixalbani opened a pull request:

    https://github.com/apache/zeppelin/pull/2867

    ZEPPELIN-3332

    Zeppelin login fails with NPE if ldapRealm.authorizationEnabled is not set true
    
    Issue was introduced by pull https://github.com/apache/zeppelin/pull/2498
    
    ### What is this PR for?
    A few sentences describing the overall goals of the pull request's commits.
    First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-3332
    
    ### How should this be tested?
    * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
    * Strongly recommended: add automated unit tests for any new or changed behavior
    * Outline any manual steps to test the PR here.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/felixalbani/zeppelin ZEPPELIN-3332

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2867.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2867
    
----
commit ceb7b6f837cfe196fd1a9b51abbffe0c31ee7e71
Author: bag_of_tricks <fa...@...>
Date:   2018-03-14T14:44:25Z

    ZEPPELIN-3332
    
    Zeppelin login fails with NPE if ldapRealm.authorizationEnabled is not set true
    
    Issue was introduced by pull https://github.com/apache/zeppelin/pull/2498

----


---

[GitHub] zeppelin pull request #2867: ZEPPELIN-3332 Zeppelin login fails with NPE if ...

Posted by felixalbani <gi...@git.apache.org>.

Github user felixalbani closed the pull request at:

    https://github.com/apache/zeppelin/pull/2867


---

[GitHub] zeppelin issue #2867: ZEPPELIN-3332

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2867
  
    LGTM


---

[GitHub] zeppelin issue #2867: ZEPPELIN-3332 Zeppelin login fails with NPE if ldapRea...

Posted by gd-asharov <gi...@git.apache.org>.

Github user gd-asharov commented on the issue:

    https://github.com/apache/zeppelin/pull/2867
  
    +1, please merge it


---

[GitHub] zeppelin issue #2867: ZEPPELIN-3332

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2867
  
    @herval
    @Leemoonsoo 


---

[GitHub] zeppelin issue #2867: ZEPPELIN-3332 Zeppelin login fails with NPE if ldapRea...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2867
  
    Thanks @felixalbani for contribution. I'm merging it to master and branch-0.8 if no further comment.


---