You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by David Chen <dc...@linkedin.com> on 2014/07/07 05:39:07 UTC
Review Request 23300: SAMZA-285: Use Apache Rat for release audit checks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23300/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMZA-285
https://issues.apache.org/jira/browse/SAMZA-285
Repository: samza
Description
-------
SAMZA-285: Use Apache Rat for release audit tests.
Diffs
-----
build.gradle f1a458b8c4cbe6e38f28ba3c5bd9099590c7abde
gradle/license.gradle 82aca213d53cb81c17e705973c4f30d28212d312
gradle/rat-output-to-html.xsl PRE-CREATION
gradle/rat.gradle PRE-CREATION
Diff: https://reviews.apache.org/r/23300/diff/
Testing
-------
Manual.
Thanks,
David Chen
Re: Review Request 23300: SAMZA-285: Use Apache Rat for release audit checks
Posted by Jakob Homan <jg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23300/#review47393
-----------------------------------------------------------
Looking good.
* rat doesn't seem to run as part of the check command, as the old license plugin did. We should have it do so.
* Please add gradle doc comment to the rat command so it shows up in ./gradlew tasks description
* buildscript.gradle has both a repo and a dependency for the old plugin that can now be removed.
- Jakob Homan
On July 6, 2014, 8:39 p.m., David Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23300/
> -----------------------------------------------------------
>
> (Updated July 6, 2014, 8:39 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-285
> https://issues.apache.org/jira/browse/SAMZA-285
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-285: Use Apache Rat for release audit tests.
>
>
> Diffs
> -----
>
> build.gradle f1a458b8c4cbe6e38f28ba3c5bd9099590c7abde
> gradle/license.gradle 82aca213d53cb81c17e705973c4f30d28212d312
> gradle/rat-output-to-html.xsl PRE-CREATION
> gradle/rat.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23300/diff/
>
>
> Testing
> -------
>
> Manual.
>
>
> Thanks,
>
> David Chen
>
>
Re: Review Request 23300: SAMZA-285: Use Apache Rat for release audit checks
Posted by Jakob Homan <jg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23300/#review47450
-----------------------------------------------------------
build.gradle
<https://reviews.apache.org/r/23300/#comment83280>
Shouldn't exclude markdown since they're generally creative documents (user guides, etc.) and therefore need licenses. Individual machine-generated markdown files will need to be explicitly excluded.
- Jakob Homan
On July 7, 2014, 10:40 p.m., David Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23300/
> -----------------------------------------------------------
>
> (Updated July 7, 2014, 10:40 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-285
> https://issues.apache.org/jira/browse/SAMZA-285
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-285: Use Apache Rat for release audit tests.
>
>
> Diffs
> -----
>
> build.gradle f1a458b8c4cbe6e38f28ba3c5bd9099590c7abde
> gradle/buildscript.gradle 739a9c1537f61bf59166e6403bcb841415bfe298
> gradle/license.gradle 82aca213d53cb81c17e705973c4f30d28212d312
> gradle/rat.gradle PRE-CREATION
> gradle/resources/rat-output-to-html.xsl PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23300/diff/
>
>
> Testing
> -------
>
> Manual.
>
>
> Thanks,
>
> David Chen
>
>
Re: Review Request 23300: SAMZA-285: Use Apache Rat for release audit checks
Posted by David Chen <dc...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23300/
-----------------------------------------------------------
(Updated July 8, 2014, 9:35 p.m.)
Review request for samza.
Changes
-------
Re-incuding Markdown files in Rat checks. However, I have excluded README.md and RELEASE.md in the source root. It does not seem like standard practice to add a license comment to those files.
Bugs: SAMZA-285
https://issues.apache.org/jira/browse/SAMZA-285
Repository: samza
Description
-------
SAMZA-285: Use Apache Rat for release audit tests.
Diffs (updated)
-----
build.gradle f1a458b8c4cbe6e38f28ba3c5bd9099590c7abde
docs/learn/documentation/0.7.0/jobs/reprocessing.md 4c92ef96fa52c0df6ca02f553f68091333d7ede6
gradle/buildscript.gradle 739a9c1537f61bf59166e6403bcb841415bfe298
gradle/license.gradle 82aca213d53cb81c17e705973c4f30d28212d312
gradle/rat.gradle PRE-CREATION
gradle/resources/rat-output-to-html.xsl PRE-CREATION
Diff: https://reviews.apache.org/r/23300/diff/
Testing
-------
Manual.
Thanks,
David Chen
Re: Review Request 23300: SAMZA-285: Use Apache Rat for release audit checks
Posted by David Chen <dc...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23300/
-----------------------------------------------------------
(Updated July 8, 2014, 5:40 a.m.)
Review request for samza.
Changes
-------
I have turned the Rat task into a plugin with the configuration specifying exclusions in the root build.gradle. The plugin injects a Rat task as a dependency on the root project's "check" and runs the Rat task at the beginning when gradle build is invoked.
The Rat task first invokes the Rat Anttask to generate an XML report. Then, it parses the XML report and prints a list of all files that do not pass the license check. Finally, it performs an XSLT to generate the HTML report.
Bugs: SAMZA-285
https://issues.apache.org/jira/browse/SAMZA-285
Repository: samza
Description
-------
SAMZA-285: Use Apache Rat for release audit tests.
Diffs (updated)
-----
build.gradle f1a458b8c4cbe6e38f28ba3c5bd9099590c7abde
gradle/buildscript.gradle 739a9c1537f61bf59166e6403bcb841415bfe298
gradle/license.gradle 82aca213d53cb81c17e705973c4f30d28212d312
gradle/rat.gradle PRE-CREATION
gradle/resources/rat-output-to-html.xsl PRE-CREATION
Diff: https://reviews.apache.org/r/23300/diff/
Testing
-------
Manual.
Thanks,
David Chen
Re: Review Request 23300: SAMZA-285: Use Apache Rat for release audit checks
Posted by David Chen <dc...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23300/
-----------------------------------------------------------
(Updated July 7, 2014, 6:36 p.m.)
Review request for samza.
Changes
-------
Addressed all code review comments except for running the rat task as part of check. It does not appear that the Rat Ant task has an option to print out the list of files that do not pass the check, but since the task can output XML, I am going to try to add some code to parse the XML and dump the list of files that do not pass the test.
Bugs: SAMZA-285
https://issues.apache.org/jira/browse/SAMZA-285
Repository: samza
Description
-------
SAMZA-285: Use Apache Rat for release audit tests.
Diffs (updated)
-----
build.gradle f1a458b8c4cbe6e38f28ba3c5bd9099590c7abde
gradle/buildscript.gradle 739a9c1537f61bf59166e6403bcb841415bfe298
gradle/license.gradle 82aca213d53cb81c17e705973c4f30d28212d312
gradle/rat.gradle PRE-CREATION
gradle/resources/rat-output-to-html.xsl PRE-CREATION
Diff: https://reviews.apache.org/r/23300/diff/
Testing
-------
Manual.
Thanks,
David Chen
Re: Review Request 23300: SAMZA-285: Use Apache Rat for release audit checks
Posted by Jakob Homan <jg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23300/#review47391
-----------------------------------------------------------
gradle/rat-output-to-html.xsl
<https://reviews.apache.org/r/23300/#comment83123>
Can we put this in gradle/resources/rat-output-to-html.xsl? That way the gradle dir is just gradle files.
gradle/rat.gradle
<https://reviews.apache.org/r/23300/#comment83124>
Also need
**/.project
**/.settings
**/*.iml
**/*.iws
**/*.ipr
- Jakob Homan
On July 6, 2014, 8:39 p.m., David Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23300/
> -----------------------------------------------------------
>
> (Updated July 6, 2014, 8:39 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-285
> https://issues.apache.org/jira/browse/SAMZA-285
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-285: Use Apache Rat for release audit tests.
>
>
> Diffs
> -----
>
> build.gradle f1a458b8c4cbe6e38f28ba3c5bd9099590c7abde
> gradle/license.gradle 82aca213d53cb81c17e705973c4f30d28212d312
> gradle/rat-output-to-html.xsl PRE-CREATION
> gradle/rat.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23300/diff/
>
>
> Testing
> -------
>
> Manual.
>
>
> Thanks,
>
> David Chen
>
>