You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/11/17 02:22:44 UTC
[kudu-CR] Fix compiler warnings in tablet replacement-itest
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8584
to review the following change.
Change subject: Fix compiler warnings in tablet_replacement-itest
......................................................................
Fix compiler warnings in tablet_replacement-itest
This patch removes the following compiler warnings:
[879/1023] Building CXX object src/kudu/inte...ment-itest.dir/tablet_replacement-itest.cc.o
../../src/kudu/integration-tests/tablet_replacement-itest.cc:370:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
cluster_->tablet_server(kFollower1Index)->Pause();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/kudu/integration-tests/tablet_replacement-itest.cc:371:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
cluster_->tablet_server(kFollower2Index)->Pause();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Change-Id: I5f9f65a73d2fe0e4b6d75010628fd36a57f98def
---
M src/kudu/integration-tests/tablet_replacement-itest.cc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/8584/1
--
To view, visit http://gerrit.cloudera.org:8080/8584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f9f65a73d2fe0e4b6d75010628fd36a57f98def
Gerrit-Change-Number: 8584
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] Fix compiler warnings in tablet replacement-itest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8584 )
Change subject: Fix compiler warnings in tablet_replacement-itest
......................................................................
Patch Set 1:
that's fun: https://gerrit.cloudera.org/#/c/8582/
--
To view, visit http://gerrit.cloudera.org:8080/8584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f9f65a73d2fe0e4b6d75010628fd36a57f98def
Gerrit-Change-Number: 8584
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 17 Nov 2017 02:23:42 +0000
Gerrit-HasComments: No
[kudu-CR] Fix compiler warnings in tablet replacement-itest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8584 )
Change subject: Fix compiler warnings in tablet_replacement-itest
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I5f9f65a73d2fe0e4b6d75010628fd36a57f98def
Gerrit-Change-Number: 8584
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Fix compiler warnings in tablet replacement-itest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8584 )
Change subject: Fix compiler warnings in tablet_replacement-itest
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f9f65a73d2fe0e4b6d75010628fd36a57f98def
Gerrit-Change-Number: 8584
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 17 Nov 2017 07:40:34 +0000
Gerrit-HasComments: No
[kudu-CR] Fix compiler warnings in tablet replacement-itest
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8584 )
Change subject: Fix compiler warnings in tablet_replacement-itest
......................................................................
Patch Set 1:
> that's fun: https://gerrit.cloudera.org/#/c/8582/
Haha oops
--
To view, visit http://gerrit.cloudera.org:8080/8584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f9f65a73d2fe0e4b6d75010628fd36a57f98def
Gerrit-Change-Number: 8584
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 17 Nov 2017 02:26:42 +0000
Gerrit-HasComments: No
[kudu-CR] Fix compiler warnings in tablet replacement-itest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8584 )
Change subject: Fix compiler warnings in tablet_replacement-itest
......................................................................
Fix compiler warnings in tablet_replacement-itest
This patch removes the following compiler warnings:
[879/1023] Building CXX object src/kudu/inte...ment-itest.dir/tablet_replacement-itest.cc.o
../../src/kudu/integration-tests/tablet_replacement-itest.cc:370:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
cluster_->tablet_server(kFollower1Index)->Pause();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/kudu/integration-tests/tablet_replacement-itest.cc:371:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
cluster_->tablet_server(kFollower2Index)->Pause();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Change-Id: I5f9f65a73d2fe0e4b6d75010628fd36a57f98def
Reviewed-on: http://gerrit.cloudera.org:8080/8584
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/tablet_replacement-itest.cc
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/8584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f9f65a73d2fe0e4b6d75010628fd36a57f98def
Gerrit-Change-Number: 8584
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Fix compiler warnings in tablet replacement-itest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8584 )
Change subject: Fix compiler warnings in tablet_replacement-itest
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f9f65a73d2fe0e4b6d75010628fd36a57f98def
Gerrit-Change-Number: 8584
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 17 Nov 2017 02:24:29 +0000
Gerrit-HasComments: No