[GitHub] [flink-docker] zentol commented on pull request #158: [ADD-SYMLINKS] Add symlinks for FLINK_VERSION to FLINK_RELEASE jars

["zentol (via GitHub)" <gi...@apache.org>]

zentol commented on PR #158:
URL: https://github.com/apache/flink-docker/pull/158#issuecomment-1584314651

   > Or are you saying that it's unsafe to deploy mixed flink patch/bugfix versions (e.g. some references to 1.16.1 & other references to 1.16.2 in the same cluster)?
   
   This is the unsafe bit I was referring to.
   
   > I'm not sure I follow your intent here... are you saying that 1.16.1 -> 1.16.2 is an unsafe version transition to happen automatically?
   
   This may be another unsafe bit, depending on how you deploy Flink.
   Let's say you have a cluster with HA.
   You can't just upgrade all the pods to a newer version, but need to stop all jobs with a savepoint, upgrade _all_ pods (== upgrade the cluster), then re-submit the jobs with their respective savepoint.
   
   > containerized.master.env.ENABLE_BUILT_IN_PLUGINS: "flink-s3-fs-presto-1.16.1.jar"
   > containerized.taskmanager.env.ENABLE_BUILT_IN_PLUGINS: "flink-s3-fs-presto-1.16.1.jar"
   
   These shouldn't handled by the operator itself, but by the docker entrypoint:
   https://github.com/apache/flink-docker/blob/master/1.17/scala_2.12-java11-ubuntu/docker-entrypoint.sh#L41
   
   So we're back in good ol' bash-land, and it boils down to whether that method works with `*`.
   At a glance, it appears to not work. `mkdir`/`ln` work fine, but the file existence checking isn't expanding `*`. So if we want to go down this route, maybe we can adjust this line to use `ls` (which totally works) instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org